Bug 81674 - xdg-open fails if your Window Manager is LXDE but you don't have pcmanfm
Summary: xdg-open fails if your Window Manager is LXDE but you don't have pcmanfm
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.1.0
Hardware: All Linux (All)
: medium normal
Assignee: thayne
QA Contact:
URL:
Whiteboard:
Keywords: patch
: 103146 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-23 13:05 UTC by Paul
Modified: 2018-02-27 21:59 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to work if pcmanfm doesn't exist in lxde or lxqt (494 bytes, patch)
2017-05-17 06:11 UTC, thayne
Details | Splinter Review
xdg-utils-bug-81674.patch (512 bytes, patch)
2017-09-27 18:56 UTC, idarktemplar
Details | Splinter Review
xdg-open fix for LXQt (1.29 KB, patch)
2017-12-20 15:46 UTC, Palo Kisa
Details | Splinter Review

Description Paul 2014-07-23 13:05:52 UTC
The problem is that xdg-open assumes that you have pcmanfm if you use LXDE. So if you don't have pcmanfm, it just fails and opens nothing. Instead it should fallback to the generic method.
Comment 1 thayne 2017-05-17 05:52:55 UTC
It also assumes you have pcmanfm if you use LXQt. But the default file browser for LXQt is pcmanfm-qt (at least on archlinux)
Comment 2 thayne 2017-05-17 06:11:48 UTC
Created attachment 131382 [details] [review]
Patch to work if pcmanfm doesn't exist in lxde or lxqt

This checks to see if pcmanfm or pcmanfm-qt exist before calling them, and falls back to using open_generic.
Comment 3 idarktemplar 2017-09-27 18:56:08 UTC
Created attachment 134515 [details] [review]
xdg-utils-bug-81674.patch

I've hit same bug with xdg-utils-1.1.2. Patch worked for me, but I've updated it a bit.
Comment 4 yan12125 2017-11-11 18:20:55 UTC
LXQt can be installed without pcmanfm-qt. IMO https://github.com/luis-pereira/xdg-utils/commit/dbf58e9fd8c5e2089a13522d87d2e660e159b8e2 is a better fix.

Upstream bug report: https://github.com/lxde/lxqt/issues/1298
Comment 5 Palo Kisa 2017-12-20 15:46:11 UTC
Created attachment 136325 [details] [review]
xdg-open fix for LXQt
Comment 6 Palo Kisa 2017-12-20 15:48:22 UTC
Hi,
 please, consider the attached patch, which makes xdg-open usable again in LXQt.

thanks

palo
Comment 7 Rex Dieter 2018-02-27 21:59:07 UTC
*** Bug 103146 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.