Here is a patch that works against dbus-glib-0.71. It adds missing checks to dbus-gproxy.c because it assumes too much about received NameOwnerChanged signals. Also one memory leak patch that came from you guys, I think...
Created attachment 6920 [details] [review] proposed patch
Comment on attachment 6920 [details] [review] proposed patch This turned out to be a buggy patch. I'll attach a new one when it's been tested.
Created attachment 7401 [details] [review] proposed patch Here is the tested, fixed patch.
I'd like to look into the 'neater' option mentioned in the patch.
It seems that unassociate_proxies() should also remove the proxy from the proxy list before adding it to the data->destroyed list, because the caller destroys the proxy.
Created attachment 7809 [details] [review] proposed patch Here is a modified patch that applies against 0.72.
Don't you want to create a new info in the else part ?
Red Hat downstream report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216034
The RH bug has my alternative patch
(In reply to comment #7) > Don't you want to create a new info in the else part ? I'm not sure, because of the comment "Name owner changed or deleted" in the code: if the info was not found, doesn't that mean that there was not changing or deletion? I.e. If the info is not found, the name owner is not related to GProxies. Or am I confused?
Just wanted to note here that this is regularly crashing gnome-session, since it blanket listens to all NameOwnerChanged signals; I don't see a GNOME bugzilla issue for this, but there are probably some dups there if you looked hard enough. I think that Kimmo is right and you don't want to insert a new info object, the message was simply not related to any GProxy objects that the library was tracking.
Yep, that patch looks right to me, I'll prep a release with it in asap.
Fixed in git head, will be in dbus-glib 0.73
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.