As reported here:
I *think* it's safe to fix.
I agree with you however it causes introducing the memory leak on applications after fixing it, which uses FcConfigSetCurrent() right?
That's why I said I "*think*". That API doesn't have too many users, and a small leak that apps can fix in the future is better than the broken behavior it currently has.
gotcha. makes sense.
Fixed in git.
Please add a note to documentation saying that this function retrains a reference including the version number that this changed.
Alternative would have been to document it as claiming ownership of the referenced passed in. I'm not sure which one I actually prefer! At any rate, as long as it's documented, it's ok.