Bug 8305 - 2.4.1 parse errors for mingw
Summary: 2.4.1 parse errors for mingw
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: 2.4
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Keith Packard
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-17 07:59 UTC by Han-Wen Nienhuys
Modified: 2006-09-17 14:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Han-Wen Nienhuys 2006-09-17 07:59:40 UTC
Hi,

compiling fontconfig 2.4.1 on mingw ; 

 



/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c: In
function 'FcDirCacheMapFd':
/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c:446: error:
'size' undeclared (first use in this function)
/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c:446: error:
(Each undeclared identifier is reported only once
/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c:446: error:
for each function it appears in.)
/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c: In
function 'FcMakeDirectory':
/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c:694: error:
too many arguments to function 'mkdir'
/home/lilydev/vc/gub/target/mingw/src/fontconfig-2.4.1/src/fccache.c:696: error:
too many arguments to function 'mkdir'


suspected fixes (not a mingw expert): use stat->st_st_size for size, strip mode
argument of mkdir.
Comment 1 Keith Packard 2006-09-17 13:40:36 UTC
Have you patched the code so that it will compile on mingw? And, ideally, the
autoconf changes needed to detect these two oddities? I haven't any way to test
this myself.
Comment 2 Han-Wen Nienhuys 2006-09-17 14:25:22 UTC
the first simply was a typo, no need to check for that. 

As for mkdir, according to 

http://msdn2.microsoft.com/en-us/library/2fkk4dzw.aspx

the standard (since w95) actually is _mkdir(const char *) . There really is no
need for an autoconf check, IMO: if _WIN32 is defined, you're on windows, and
should use _mkdir. 

Patch is another issue.
Comment 3 Han-Wen Nienhuys 2006-09-17 14:35:34 UTC
(In reply to comment #2)
> 
> Patch is another issue.

see issue #8311
Comment 4 Keith Packard 2006-09-17 14:53:33 UTC
This was fixed in the patch for 8311


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.