Bug 8318 - uscore_to_wincaps crashes
Summary: uscore_to_wincaps crashes
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: high normal
Assignee: Rob Taylor
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-18 01:16 UTC by frederic heem
Modified: 2007-02-08 18:12 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description frederic heem 2006-09-18 01:16:43 UTC
uscore_to_wincaps doesn't check the input parameters uscore, it appears to be 
NULL in some cases:
#0  uscore_to_wincaps (uscore=0x0) at dbus-gobject.c:64
#1  0x00140ce2 in gerror_to_dbus_error_message 
(object_info=Variable "object_info" is not available.
) at dbus-gobject.c:842
#2  0x00141cf3 in gobject_message_function (connection=0x8b51d78, 
message=0x8b53498, user_data=0x8b50240) at dbus-gobject.c:1219
#3  0x05766af9 in _dbus_object_tree_dispatch_and_unlock (tree=0x8b51bd8, 
message=0x8b53498) at dbus-object-tree.c:842
#4  0x0575132c in dbus_connection_dispatch (connection=0x8b51d78) at 
dbus-connection.c:3820
#5  0x0013d26d in message_queue_dispatch (source=0x8b52210, callback=0, 
user_data=0x0) at dbus-gmain.c:113
#6  0x00514ffd in IA__g_main_context_dispatch (context=0x8b515d8) at 
gmain.c:1916
#7  0x0051828f in g_main_context_iterate (context=0x8b515d8, block=1, 
dispatch=1, self=0x8b50550) at gmain.c:2547
#8  0x00518639 in IA__g_main_loop_run (loop=0x8b50988) at gmain.c:2751
#9  0x08051be3 in sniffer_dbus_main () at dbus/wireshark-dbus-sniffer.c:229
#10 0x0804fcc0 in main (argc=Cannot access memory at address 0x50


Here is the function declaration that has trigger the crash:
    <method name="getInstance">
      <annotation name="org.freedesktop.DBus.GLib.CSymbol" 
value="sniffer_get"/>
      <arg type="s" name="name" direction="out">
        <annotation name="org.freedesktop.DBus.GLib.ReturnVal" value="error"/>
      </arg>
    </method>
Comment 1 frederic heem 2006-09-18 01:34:08 UTC
Actually, after checking NULL pointer in uscore_to_wincaps, it then asserts in 
g_string_append (dbus_gobject.c line 848) because, NULL pointer are AGAIN not 
checked !

Comment 2 Rob Taylor 2007-02-08 18:08:10 UTC
oops, accidental closure.
Comment 3 Rob Taylor 2007-02-08 18:12:25 UTC
Fixed in git head. Fix will be in dbus-glib 0.73


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.