Bug 8323 - pycairo 1.2 build problems on win32
Summary: pycairo 1.2 build problems on win32
Status: RESOLVED FIXED
Alias: None
Product: pycairo
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Steve Chaplin
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-18 03:54 UTC by Cedric Gustin
Modified: 2006-09-21 21:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fix pycairo-1.2 build on win32 (mingw32) + distutils setup.py script (5.64 KB, patch)
2006-09-18 03:55 UTC, Cedric Gustin
Details | Splinter Review

Description Cedric Gustin 2006-09-18 03:54:22 UTC
Currently, pycairo 1.2 does not build on win32 (with mingw32) due to some
"non-const initializer" errors in pycairo-path.c. The attached fixes this issue.
It also slightly changes setup.py to make it compatible with the
distutils-generated installer for win32 (python setup.py bdist_wininst).
Comment 1 Cedric Gustin 2006-09-18 03:55:18 UTC
Created attachment 7044 [details] [review]
Fix pycairo-1.2 build on win32 (mingw32) + distutils setup.py script
Comment 2 Steve Chaplin 2006-09-21 21:16:21 UTC
Looks like two patches mixed together.

I applied the PycairoPathiter_Tpye patch (I'd already fixed many instances of
the same problem) but left out the PyType_Ready() call.

I don't think the PycairoPathiter_Type problem is a pycairo bug, since the
'problem' C code is very similar code used in the Python source itself. I think
its a Mingw bug - mingw gcc can't compile valid C code which gcc (and other
compilers) on different platforms can compile. Its probably better to fix mingw
rather than apply workarounds to many individually projects.

The setup.py patch looks good so I applied that too.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.