Bug 83305 - Function to get quadrilaterals for area
Summary: Function to get quadrilaterals for area
Status: RESOLVED MOVED
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 18:00 UTC by giselle
Modified: 2018-08-20 21:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
poppler-page: get_quadrilaterals_for_area implementation (3.97 KB, patch)
2014-08-31 18:02 UTC, giselle
Details | Splinter Review
glib-demo: uses get_quadrilaterals_for_area (3.52 KB, patch)
2014-08-31 18:02 UTC, giselle
Details | Splinter Review

Description giselle 2014-08-31 18:00:56 UTC
Currently there is a code in glib-demo to get the quadrilaterals of the text contained in a specific selection. This is needed in order to implement text markup annotations. The following patches implement this function as part of glib api and use it in glib-demo.
Comment 1 giselle 2014-08-31 18:02:18 UTC
Created attachment 105495 [details] [review]
poppler-page: get_quadrilaterals_for_area implementation

Adding poppler_page_get_quadrilaterals_for_area to glib's api.
Comment 2 giselle 2014-08-31 18:02:59 UTC
Created attachment 105496 [details] [review]
glib-demo: uses get_quadrilaterals_for_area

Modifies glib-demo such that it uses the new function.
Comment 3 Jose Aliste 2016-07-18 22:55:44 UTC
Carlos, could we get this in? I am using evince with highlighting support more often now and I see a lot of issues because we still haven't merge this (think of a highlight that start at the end of a line and start at the beginning of the next one... then, the rectangle will be super big and you basically can't annotate other contents of the two lines containing this highlight)
Comment 4 Carlos Garcia Campos 2016-07-23 09:25:46 UTC
(In reply to Jose Aliste from comment #3)
> Carlos, could we get this in? I am using evince with highlighting support
> more often now and I see a lot of issues because we still haven't merge this
> (think of a highlight that start at the end of a line and start at the
> beginning of the next one... then, the rectangle will be super big and you
> basically can't annotate other contents of the two lines containing this
> highlight)

I don't understand it, get_quads_for_area() in evince is exactly the same code as poppler_page_get_quadrilaterals_for_area(). I'm not opposed to merge this, since that would save all this code in evince, but I don't see how this would change the evince behavior.
Comment 5 Jose Aliste 2016-07-24 19:44:51 UTC
you are right... I go confused since I haven't looked into this for a long time.... The patches we need for this I actually submitted them in a new evince bug.
Comment 6 GitLab Migration User 2018-08-20 21:41:54 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/38.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.