Bug 8344 - freebsd-dri config doesn't honor {OPT,WARN,PIC}_FLAGS and others.
Summary: freebsd-dri config doesn't honor {OPT,WARN,PIC}_FLAGS and others.
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: 6.5
Hardware: x86 (IA32) FreeBSD
: high minor
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-18 13:21 UTC by Javier Villavicencio
Modified: 2006-09-19 09:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
6.5-fbsd-configs-fix.patch (515 bytes, patch)
2006-09-18 13:23 UTC, Javier Villavicencio
Details | Splinter Review
6.5-freebsd-dri.patch (1.05 KB, patch)
2006-09-18 13:27 UTC, Javier Villavicencio
Details | Splinter Review
6.5-redirect-fix.patch (362 bytes, patch)
2006-09-18 13:27 UTC, Javier Villavicencio
Details | Splinter Review
6.5.1-freebsd-dri.patch (1.01 KB, patch)
2006-09-18 16:18 UTC, Javier Villavicencio
Details | Splinter Review

Description Javier Villavicencio 2006-09-18 13:21:00 UTC
When trying to build mesa with DRI support on Gentoo/FreeBSD, I noticed that the
OPT_FLAGS, WARN_FLAGS, PIC_FLAGS, ASM_FLAGS and X11_INCLUDES variables aren't
being included in CFLAGS properly, which prevents it from building correctly.
Also, there is an override (in freebsd-dri) to the 'default' config in which
GLW_LIB_DEPS has a dependency on -lXm thus requiring a motif library installed.
Is this intentional, or a bug?
The attached patch changes this behaviour to let it build correctly.
Also, i'm attaching a tiny patch to 'src/mesa/drivers/dri/Makefile.template'
that makes it a bit more portable regarding output redirection.
Comment 1 Javier Villavicencio 2006-09-18 13:23:08 UTC
Created attachment 7061 [details] [review]
6.5-fbsd-configs-fix.patch

This patch is just a copy from 'freebsd' C{XX}FLAGS to 'freebsd-dri'.
Comment 2 Javier Villavicencio 2006-09-18 13:27:03 UTC
Created attachment 7062 [details] [review]
6.5-freebsd-dri.patch

Sorry, wrong file attached before.
Comment 3 Javier Villavicencio 2006-09-18 13:27:52 UTC
Created attachment 7063 [details] [review]
6.5-redirect-fix.patch

Replaces >& for a more portable 2>&1 output redirection.
Comment 4 Brian Paul 2006-09-18 15:56:03 UTC
The patch to configs/freebsd-dri doesn't apply cleanly to Mesa 6.5.1 (just
released).  Could you update the patch (if it's actually still needed)?

I checked in the redirection change.
Comment 5 Javier Villavicencio 2006-09-18 16:18:54 UTC
Created attachment 7066 [details] [review]
6.5.1-freebsd-dri.patch

This is the updated patch for Mesa-6.5.1.
Comment 6 Brian Paul 2006-09-19 09:33:26 UTC
Patch appled.  Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.