Bug 83474 - build failure: pk-network-stack-connman
Summary: build failure: pk-network-stack-connman
Status: RESOLVED FIXED
Alias: None
Product: PackageKit
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 05:12 UTC by Mantas Mikulėnas
Modified: 2014-09-05 08:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mantas Mikulėnas 2014-09-04 05:12:39 UTC
I'm getting this with current packagekit-git:

  CC       libpkplugins_la-pk-sysdep.lo
  CC       libpkplugins_la-pk-engine.lo
  CC       libpkplugins_la-pk-backend-spawn.lo
  CC       libpkplugins_la-pk-transaction-db.lo
  CC       libpkplugins_la-pk-transaction-list.lo
  CC       libpkplugins_la-pk-network-stack-nm.lo
  CC       libpkplugins_la-pk-network-stack-connman.lo
  CC       packagekitd-pk-main.o
pk-network-stack-connman.c: In function 'pk_network_stack_connman_get_state':
pk-network-stack-connman.c:108:2: error: passing argument 3 of 'g_dbus_proxy_call_sync' from incompatible pointer type [-Werror]
  g_dbus_proxy_call_sync (proxy, "GetProperties", &error,
  ^
In file included from /usr/include/glib-2.0/gio/gio.h:58:0,
                 from pk-network-stack-connman.c:27:
/usr/include/glib-2.0/gio/gdbusproxy.h:178:18: note: expected 'struct GVariant *' but argument is of type 'struct GError **'
 GVariant        *g_dbus_proxy_call_sync                 (GDBusProxy          *proxy,
                  ^
pk-network-stack-connman.c:108:2: error: passing argument 6 of 'g_dbus_proxy_call_sync' from incompatible pointer type [-Werror]
  g_dbus_proxy_call_sync (proxy, "GetProperties", &error,
  ^
In file included from /usr/include/glib-2.0/gio/gio.h:58:0,
                 from pk-network-stack-connman.c:27:
/usr/include/glib-2.0/gio/gdbusproxy.h:178:18: note: expected 'struct GCancellable *' but argument is of type 'struct GHashTable **'
 GVariant        *g_dbus_proxy_call_sync                 (GDBusProxy          *proxy,
                  ^
pk-network-stack-connman.c:160:2: error: passing argument 3 of 'g_dbus_proxy_call_sync' from incompatible pointer type [-Werror]
  g_dbus_proxy_call_sync (proxy_service, "GetProperties", &error,
  ^
In file included from /usr/include/glib-2.0/gio/gio.h:58:0,
                 from pk-network-stack-connman.c:27:
/usr/include/glib-2.0/gio/gdbusproxy.h:178:18: note: expected 'struct GVariant *' but argument is of type 'struct GError **'
 GVariant        *g_dbus_proxy_call_sync                 (GDBusProxy          *proxy,
                  ^
pk-network-stack-connman.c:160:2: error: passing argument 6 of 'g_dbus_proxy_call_sync' from incompatible pointer type [-Werror]
  g_dbus_proxy_call_sync (proxy_service, "GetProperties", &error,
  ^
In file included from /usr/include/glib-2.0/gio/gio.h:58:0,
                 from pk-network-stack-connman.c:27:
/usr/include/glib-2.0/gio/gdbusproxy.h:178:18: note: expected 'struct GCancellable *' but argument is of type 'struct GHashTable **'
 GVariant        *g_dbus_proxy_call_sync                 (GDBusProxy          *proxy,
                  ^
  CC       packagekitd-pk-marshal.o
cc1: all warnings being treated as errors
  CC       packagekitd-pk-dbus.o
Makefile:1428: recipe for target 'libpkplugins_la-pk-network-stack-connman.lo' failed
make[4]: *** [libpkplugins_la-pk-network-stack-connman.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
Makefile:2231: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
Makefile:1049: recipe for target 'all' failed
make[2]: *** [all] Error 2
Makefile:603: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
Makefile:534: recipe for target 'all' failed
make: *** [all] Error 2


packagekit @ 6125d30
connman 1.24
Comment 1 Richard Hughes 2014-09-04 18:59:04 UTC
I think you're the first person in a long time to have built the connman backend -- have you got a specific need to do so? 99.99% of people either use NetworkManager or the UNIX backend. I'd really appreciate a patch to fix things up if you actually need conman support and can help.
Comment 2 Mantas Mikulėnas 2014-09-04 19:02:32 UTC
I don't use the connman backend, no; it was simply enabled by default, so I thought I'd post a note about it here. I did try disabling it afterwards, which resulted in bug 83475.
Comment 3 Richard Hughes 2014-09-05 08:51:43 UTC
commit 4eac4734a002eddc758685654f457f52107fc0b0
Author: Richard Hughes <richard@hughsie.com>
Date:   Fri Sep 5 09:51:06 2014 +0100

    Fix compile of the ConnMan network support
    
    Additionally, disable it by default as it's little used.
    Resolves: https://bugs.freedesktop.org/show_bug.cgi?id=83474


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.