Bug 83596 - reuse_framebuffer_texture_attachment does not set Layered field
Summary: reuse_framebuffer_texture_attachment does not set Layered field
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: All Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-07 21:28 UTC by vincent
Modified: 2016-11-16 19:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Copy layered field in reuse_framebuffer_texture_attachment (728 bytes, text/plain)
2014-09-07 21:28 UTC, vincent
Details

Description vincent 2014-09-07 21:28:08 UTC
Created attachment 105872 [details]
Copy layered field in reuse_framebuffer_texture_attachment

Hi,

the reuse_framebuffer_texture_attachment in src/mesa/main/fbobject.c does not copy the Layered field. This generates incorrect incomplete framebuffer statement when setting a layered fbo with a GL_DEPTH_STENCIL attachement for instance.

I've attached a patch that fix the issue.
Comment 1 Michel Dänzer 2014-09-08 08:38:40 UTC
Please submit the patch directly to the mesa-dev mailing list.
Comment 2 Nanley Chery 2016-11-16 19:35:28 UTC
This issue was fixed by the following commit:

commit 35859d5bbba998aa41ec87bc53d946add4662dea
Author: Dave Airlie <airlied@redhat.com>
Date:   Mon Feb 29 17:16:10 2016 +1000

    mesa/fbobject: propogate Layered when reusing attachments.

    When reusing a depth attachment as a stencil, we need to propogate
    the layered bit, otherwise we fail to complete the framebuffer.

    discovered running ./bin/fbo-depth-array depth-layered-clear
    on virgl on haswell.

    Reviewed-by: Marek Olšák <marek.olsak@amd.com>
    Cc: "11.1 11.2" <mesa-stable@lists.freedesktop.org>
    Signed-off-by: Dave Airlie <airlied@redhat.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.