Bug 83759 - [BSW regression]igt/kms_flip subcases cause "WARNING: CPU: 0 PID: 3785 at drivers/gpu/drm/i915/intel_display.c:3486 intel_crtc_wait_for_pending_flips+0xdd/0x197 [i915]()"
Summary: [BSW regression]igt/kms_flip subcases cause "WARNING: CPU: 0 PID: 3785 at dri...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: highest major
Assignee: Jani Nikula
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-11 09:55 UTC by Guo Jinxian
Modified: 2017-02-10 08:58 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg (124.72 KB, text/plain)
2014-09-11 09:55 UTC, Guo Jinxian
no flags Details

Description Guo Jinxian 2014-09-11 09:55:22 UTC
Created attachment 106120 [details]
dmesg

==System Environment==
--------------------------
Regression: Yes.
Good commit on -next-queued: 17c58fe801f5588c5904cc2f15620f7f5a465b53

Non-working platforms: BSW

==kernel==
--------------------------
origin/drm-intel-nightly: 72faa6a63351879b381bd9e4013f38bc94f11999(fails)
    drm-intel-nightly: 2014y-09m-10d-18h-58m-22s integration manifest
origin/drm-intel-next-queued:449b3795f2a48c51ad1714cd5eab0179e37c6a85(fails)
    drm/i915: create intel_update_pipe_size()
origin/drm-intel-fixes: 7a98948f3b536ca9a077e84966ddc0e9f53726df(works)
    drm/i915: Wait for vblank before enabling the TV encoder

==Bug detailed description==
-----------------------------
igt/kms_flip subcases cause "WARNING: CPU: 0 PID: 3785 at drivers/gpu/drm/i915/intel_display.c:3486 intel_crtc_wait_for_pending_flips+0xdd/0x197 [i915]()"

Case list:
igt/kms_flip/bcs-flip-vs-panning
igt/kms_flip/bcs-flip-vs-panning-interruptible

Output:
[root@x-bsw01 tests]# ./kms_flip --run-subtest bcs-flip-vs-panning
IGT-Version: 1.8-gd9d3f4b (x86_64) (Linux: 3.17.0-rc4_drm-intel-nightly_72faa6_20140911+ x86_64)
Using monotonic timestamps
Beginning bcs-flip-vs-panning on crtc 8, connector 31
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 8, connector 31: PASSED

Beginning bcs-flip-vs-panning on crtc 13, connector 31
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 13, connector 31: PASSED

Subtest bcs-flip-vs-panning: SUCCESS (128.193s)
[root@x-bsw01 tests]# dmesg -r|egrep ""<[1-4]>""|grep drm
<4>[  108.356637] WARNING: CPU: 0 PID: 3785 at drivers/gpu/drm/i915/intel_display.c:3486 intel_crtc_wait_for_pending_flips+0xdd/0x197 [i915]()
<4>[  108.356641] Modules linked in: ip6table_filter ip6_tables iptable_filter ip_tables ebtable_nat ebtables x_tables ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic pcspkr serio_raw snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm i2c_i801 snd_timer r8169 snd soundcore battery ac option usb_wwan usbserial i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
<4>[  108.356696] CPU: 0 PID: 3785 Comm: kms_flip Not tainted 3.17.0-rc4_drm-intel-nightly_72faa6_20140911+ #2340
<4>[  108.356885]  [<ffffffffa0017fad>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  108.356903]  [<ffffffffa001b9a9>] ? drm_mode_setcrtc+0x3e6/0x48b [drm]
<4>[  108.356919]  [<ffffffffa001063c>] ? drm_ioctl+0x279/0x3bc [drm]
<4>[  108.356944]  [<ffffffffa001b5c3>] ? drm_mode_setplane+0x16d/0x16d [drm]
<4>[  108.357027] WARNING: CPU: 0 PID: 3785 at drivers/gpu/drm/i915/intel_display.c:3492 intel_crtc_wait_for_pending_flips+0x115/0x197 [i915]()
<4>[  108.357033] Modules linked in: ip6table_filter ip6_tables iptable_filter ip_tables ebtable_nat ebtables x_tables ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic pcspkr serio_raw snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm i2c_i801 snd_timer r8169 snd soundcore battery ac option usb_wwan usbserial i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
<4>[  108.357082] CPU: 0 PID: 3785 Comm: kms_flip Tainted: G        W      3.17.0-rc4_drm-intel-nightly_72faa6_20140911+ #2340
<4>[  108.357293]  [<ffffffffa0017fad>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  108.357310]  [<ffffffffa001b9a9>] ? drm_mode_setcrtc+0x3e6/0x48b [drm]
<4>[  108.357325]  [<ffffffffa001063c>] ? drm_ioctl+0x279/0x3bc [drm]
<4>[  108.357349]  [<ffffffffa001b5c3>] ? drm_mode_setplane+0x16d/0x16d [drm]
<4>[  170.924626] WARNING: CPU: 3 PID: 3785 at drivers/gpu/drm/i915/intel_display.c:3486 intel_crtc_wait_for_pending_flips+0xdd/0x197 [i915]()
<4>[  170.924631] Modules linked in: ip6table_filter ip6_tables iptable_filter ip_tables ebtable_nat ebtables x_tables ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic pcspkr serio_raw snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm i2c_i801 snd_timer r8169 snd soundcore battery ac option usb_wwan usbserial i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
<4>[  170.924686] CPU: 3 PID: 3785 Comm: kms_flip Tainted: G        W      3.17.0-rc4_drm-intel-nightly_72faa6_20140911+ #2340
<4>[  170.924874]  [<ffffffffa0017fad>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  170.924893]  [<ffffffffa001b9a9>] ? drm_mode_setcrtc+0x3e6/0x48b [drm]
<4>[  170.924908]  [<ffffffffa001063c>] ? drm_ioctl+0x279/0x3bc [drm]
<4>[  170.924934]  [<ffffffffa001b5c3>] ? drm_mode_setplane+0x16d/0x16d [drm]

==Reproduce steps==
---------------------------- 
1. ./kms_flip --run-subtest bcs-flip-vs-panning
Comment 1 Guo Jinxian 2014-11-11 01:16:48 UTC
e17ac6db2ef99388b750b2141c11974dc5742913 is the first bad commit 
commit e17ac6db2ef99388b750b2141c11974dc5742913 
Author: Ville Syrjälä <ville.syrjala@linux.intel.com> 
AuthorDate: Thu Oct 9 19:37:15 2014 +0300 
Commit: Jani Nikula <jani.nikula@intel.com> 
CommitDate: Thu Oct 16 14:58:44 2014 +0300 

drm/i915: Don't trust the DP_DETECT bit for eDP ports on CHV 

On CHV the display DDC pins may be muxed to an alternate function if 
there's no need for DDC on a specific port, which is the case for eDP 
ports since there's no way to plug in a DP++ HDMI dongle. 

This causes problems when trying to determine if the port is present 
since the the DP_DETECTED bit is the latched state of the DDC SDA pin 
at boot. If the DDC pins are muxed to an alternate function the bit 
may indicate that the port isn't present. 

To work around this look at the VBT as well as the DP_DETECTED bit 
to determine if we should attempt registering an eDP port. Do this 
only for ports B and C since port D doesn't support eDP (no PPS/BLC). 

In theory someone could also wire up a normal DP port w/o DDC lines. 
That would just mean that simple DP++ HDMI dongles wouldn't work 
on such a port. With this change we would still fail to register 
such DP ports. But let's hope no one wires their board in such a way, 
and if they do we can extend the VBT checks to cover normal DP ports 
as well. 

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84265 
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> 
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> 
Signed-off-by: Jani Nikula <jani.nikula@intel.com> 

:040000 040000 0b768aac5e80cee20320cf387f0a9dab0c9f4cf8 581bee5771f0039afb5db5ede0540876e7d9b0ee M drivers
Comment 2 Jani Nikula 2014-11-11 08:42:46 UTC
(In reply to Guo Jinxian from comment #1)
> e17ac6db2ef99388b750b2141c11974dc5742913 is the first bad commit 
> commit e17ac6db2ef99388b750b2141c11974dc5742913 
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com> 
> AuthorDate: Thu Oct 9 19:37:15 2014 +0300 
> Commit: Jani Nikula <jani.nikula@intel.com> 
> CommitDate: Thu Oct 16 14:58:44 2014 +0300 

Come on, the bug was reported 2014-09-11 12:55:22 EEST, a full month before the supposed culprit was committed.
Comment 3 Guo Jinxian 2014-11-12 06:24:02 UTC
(In reply to Jani Nikula from comment #2)
> (In reply to Guo Jinxian from comment #1)
> > e17ac6db2ef99388b750b2141c11974dc5742913 is the first bad commit 
> > commit e17ac6db2ef99388b750b2141c11974dc5742913 
> > Author: Ville Syrjälä <ville.syrjala@linux.intel.com> 
> > AuthorDate: Thu Oct 9 19:37:15 2014 +0300 
> > Commit: Jani Nikula <jani.nikula@intel.com> 
> > CommitDate: Thu Oct 16 14:58:44 2014 +0300 
> 
> Come on, the bug was reported 2014-09-11 12:55:22 EEST, a full month before
> the supposed culprit was committed.

The result on pristine fail commit(449b3795f2a48c51ad1714cd5eab0179e37c6a85) was changed to skip now. And the dmesg warning still able to reproduce on latest next-queued. 
I tried to bisected it between 449b3795f2a48c51ad1714cd5eab0179e37c6a85 and latest next-queud, and found that e17ac6db2ef99388b750b2141c11974dc5742913 is the first bad commit.
Comment 4 Daniel Vetter 2014-11-14 08:52:37 UTC
(In reply to Guo Jinxian from comment #3)
> The result on pristine fail commit(449b3795f2a48c51ad1714cd5eab0179e37c6a85)
> was changed to skip now. And the dmesg warning still able to reproduce on
> latest next-queued.

I don't have 449b3795f2a48c51ad1714cd5eab0179e37c6a85 here ...

Also what exactly changed to skip?

> I tried to bisected it between 449b3795f2a48c51ad1714cd5eab0179e37c6a85 and
> latest next-queud, and found that e17ac6db2ef99388b750b2141c11974dc5742913
> is the first bad commit.

Yeah that one just means we've found the DP port again or so.
Comment 5 Daniel Vetter 2014-11-14 08:53:49 UTC
I.e. please retry to bisect something else.
Comment 6 Guo Jinxian 2014-11-17 07:25:05 UTC
(In reply to Daniel Vetter from comment #5)
> I.e. please retry to bisect something else.

The case fails on latest -nightly(e49ebf9ed863e9522260ebd7bd0338ef5641c0e6), I reported a new bug 86373. About this one, I will try to bisect to again later.
Comment 7 Guo Jinxian 2014-11-21 03:28:03 UTC
I checked the parents commit of the bad commit a bisected. It is skips

On commit 1180e20606fd7c5d76dc5b2a1594fa51ba5a0f31, the result is skips
root@x-bsw03:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_flip --run-subtest bcs-flip-vs-panning
IGT-Version: 1.7-g5c7bcb1 (x86_64) (Linux: 3.17.0-rc5_glody_1180e2_20141110+ x86_64)
Using monotonic timestamps
Test requirement not met in function run_test, file kms_flip.c:1399:
Test requirement: modes
Subtest bcs-flip-vs-panning: SKIP

The bad commit is passed and have dmesg warning.

On commit e17ac6db2ef99388b750b2141c11974dc5742913, the result is dmesg warning.
root@x-bsw03:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_flip --run-subtest bcs-flip-vs-panning
IGT-Version: 1.7-g5c7bcb1 (x86_64) (Linux: 3.17.0-rc5_glody_e17ac6_20141110+ x86_64)
Using monotonic timestamps
Beginning bcs-flip-vs-panning on crtc 8, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 8, connector 29: PASSED

Beginning bcs-flip-vs-panning on crtc 13, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..

bcs-flip-vs-panning on crtc 13, connector 29: PASSED

Subtest bcs-flip-vs-panning: SUCCESS
root@x-bsw03:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# dmesg -r|egrep "<[1-4]>"|grep drm
<4>[  115.100962] WARNING: CPU: 1 PID: 4303 at drivers/gpu/drm/i915/intel_display.c:3473 intel_crtc_wait_for_pending_flips+0xd2/0x188 [i915]()
<4>[  115.100966] Modules linked in: ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_controller serio_raw pcspkr snd_hda_codec snd_hwdep snd_pcm i2c_i801 r8169 snd_timer snd soundcore battery ac acpi_cpufreq option usb_wwan usbserial i915 button video drm_kms_helper drm
<4>[  115.101190]  [<ffffffffa000bd74>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  115.101208]  [<ffffffffa000f466>] ? drm_mode_setcrtc+0x388/0x47e [drm]
<4>[  115.101225]  [<ffffffffa0004749>] ? drm_ioctl+0x344/0x3b3 [drm]
<4>[  115.101242]  [<ffffffffa000f0de>] ? drm_mode_setplane+0x16b/0x16b [drm]
<4>[  115.101316] WARNING: CPU: 1 PID: 4303 at drivers/gpu/drm/i915/intel_display.c:3479 intel_crtc_wait_for_pending_flips+0x10a/0x188 [i915]()
<4>[  115.101322] Modules linked in: ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_controller serio_raw pcspkr snd_hda_codec snd_hwdep snd_pcm i2c_i801 r8169 snd_timer snd soundcore battery ac acpi_cpufreq option usb_wwan usbserial i915 button video drm_kms_helper drm
<4>[  115.101575]  [<ffffffffa000bd74>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  115.101593]  [<ffffffffa000f466>] ? drm_mode_setcrtc+0x388/0x47e [drm]
<4>[  115.101609]  [<ffffffffa0004749>] ? drm_ioctl+0x344/0x3b3 [drm]
<4>[  115.101626]  [<ffffffffa000f0de>] ? drm_mode_setplane+0x16b/0x16b [drm]
<4>[  177.806725] WARNING: CPU: 1 PID: 4303 at drivers/gpu/drm/i915/intel_display.c:3473 intel_crtc_wait_for_pending_flips+0xd2/0x188 [i915]()
<4>[  177.806729] Modules linked in: ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_controller serio_raw pcspkr snd_hda_codec snd_hwdep snd_pcm i2c_i801 r8169 snd_timer snd soundcore battery ac acpi_cpufreq option usb_wwan usbserial i915 button video drm_kms_helper drm
<4>[  177.806954]  [<ffffffffa000bd74>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  177.806972]  [<ffffffffa000f466>] ? drm_mode_setcrtc+0x388/0x47e [drm]
<4>[  177.806989]  [<ffffffffa0004749>] ? drm_ioctl+0x344/0x3b3 [drm]
<4>[  177.807006]  [<ffffffffa000f0de>] ? drm_mode_setplane+0x16b/0x16b [drm]

I tried to find good commit on the front of skip commit, and found that the result all skipps. Maybe this issue isn't a regression issue.
Comment 8 Daniel Vetter 2014-11-21 08:50:31 UTC
Ah, bad mixup on my side. This should be address with

commit cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Tue May 27 21:33:09 2014 +0300

    drm/i915: Ignore SURFLIVE and flip counter when the GPU gets reset

from -fixes. Please retest.
Comment 9 Guo Jinxian 2014-11-24 03:24:44 UTC
(In reply to Daniel Vetter from comment #8)
> Ah, bad mixup on my side. This should be address with
> 
> commit cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date:   Tue May 27 21:33:09 2014 +0300
> 
>     drm/i915: Ignore SURFLIVE and flip counter when the GPU gets reset
> 
> from -fixes. Please retest.

The dmesg warning still able to reproduce on latest -fixes(cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7).

[root@x-bsw01 tests]# ./kms_flip --run-subtest bcs-flip-vs-panning
IGT-Version: 1.8-gd807891 (x86_64) (Linux: 3.18.0-rc5_kcloud_cb4975_20141124+ x86_64)
Using monotonic timestamps
Beginning bcs-flip-vs-panning on crtc 8, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 8, connector 29: PASSED

Beginning bcs-flip-vs-panning on crtc 13, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 13, connector 29: PASSED

Subtest bcs-flip-vs-panning: SUCCESS (126.714s)
[root@x-bsw01 tests]# dmesg -r|egrep "<[1-4]>"|grep drm
<3>[  216.435824] [drm:valleyview_pipestat_irq_handler] *ERROR* pipe A underrun
<4>[  276.490606] WARNING: CPU: 3 PID: 3852 at drivers/gpu/drm/i915/intel_display.c:3473 intel_crtc_wait_for_pending_flips+0xd7/0x18d [i915]()
<4>[  276.490610] Modules linked in: iTCO_wdt iTCO_vendor_support dm_mod serio_raw pcspkr snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_controller snd_hda_codec lpc_ich mfd_core i2c_i801 snd_hwdep snd_pcm snd_timer snd soundcore battery ac acpi_cpufreq option usb_wwan usbserial i915 button video drm_kms_helper dr
<4>[  276.490842]  [<ffffffffa000bea2>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  276.490860]  [<ffffffffa000f62c>] ? drm_mode_setcrtc+0x38b/0x481 [drm]
<4>[  276.490885]  [<ffffffffa00047e3>] ? drm_ioctl+0x344/0x3b3 [drm]
<4>[  276.490902]  [<ffffffffa000f2a1>] ? drm_mode_setplane+0x1cd/0x1cd [drm]
<4>[  276.490991] WARNING: CPU: 3 PID: 3852 at drivers/gpu/drm/i915/intel_display.c:3479 intel_crtc_wait_for_pending_flips+0x10f/0x18d [i915]()
<4>[  276.490997] Modules linked in: iTCO_wdt iTCO_vendor_support dm_mod serio_raw pcspkr snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_controller snd_hda_codec lpc_ich mfd_core i2c_i801 snd_hwdep snd_pcm snd_timer snd soundcore battery ac acpi_cpufreq option usb_wwan usbserial i915 button video drm_kms_helper dr
<4>[  276.491252]  [<ffffffffa000bea2>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  276.491270]  [<ffffffffa000f62c>] ? drm_mode_setcrtc+0x38b/0x481 [drm]
<4>[  276.491293]  [<ffffffffa00047e3>] ? drm_ioctl+0x344/0x3b3 [drm]
<4>[  276.491311]  [<ffffffffa000f2a1>] ? drm_mode_setplane+0x1cd/0x1cd [drm]
<3>[  279.070298] [drm:valleyview_pipestat_irq_handler] *ERROR* pipe B underrun
<4>[  339.125445] WARNING: CPU: 3 PID: 3852 at drivers/gpu/drm/i915/intel_display.c:3473 intel_crtc_wait_for_pending_flips+0xd7/0x18d [i915]()
<4>[  339.125449] Modules linked in: iTCO_wdt iTCO_vendor_support dm_mod serio_raw pcspkr snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_controller snd_hda_codec lpc_ich mfd_core i2c_i801 snd_hwdep snd_pcm snd_timer snd soundcore battery ac acpi_cpufreq option usb_wwan usbserial i915 button video drm_kms_helper dr
<4>[  339.125682]  [<ffffffffa000bea2>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
<4>[  339.125700]  [<ffffffffa000f62c>] ? drm_mode_setcrtc+0x38b/0x481 [drm]
<4>[  339.125725]  [<ffffffffa00047e3>] ? drm_ioctl+0x344/0x3b3 [drm]
<4>[  339.125742]  [<ffffffffa000f2a1>] ? drm_mode_setplane+0x1cd/0x1cd [drm]
<3>[  341.603419] [drm:i9xx_set_fifo_underrun_reporting] *ERROR* pipe B underrun
<3>[  341.603547] [drm:valleyview_pipestat_irq_handler] *ERROR* pipe B underrun
Comment 10 Daniel Vetter 2014-11-24 16:11:17 UTC
Readding regression - Guo when you drop bisected please replace it with "regression" next time around. After all it's still a regression even when the bisect result turns out to be invalid.

On to bug itself: No idea at all.
Comment 11 Ville Syrjala 2014-11-24 16:16:48 UTC
(In reply to Guo Jinxian from comment #9)
> (In reply to Daniel Vetter from comment #8)
> > Ah, bad mixup on my side. This should be address with
> > 
> > commit cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7
> > Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Date:   Tue May 27 21:33:09 2014 +0300
> > 
> >     drm/i915: Ignore SURFLIVE and flip counter when the GPU gets reset
> > 
> > from -fixes. Please retest.
> 
> The dmesg warning still able to reproduce on latest
> -fixes(cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7).

A lot more interesting would be knowing whether it still happens on nightly.
Comment 12 Guo Jinxian 2014-11-27 07:00:31 UTC
(In reply to Ville Syrjala from comment #11)
> (In reply to Guo Jinxian from comment #9)
> > (In reply to Daniel Vetter from comment #8)
> > > Ah, bad mixup on my side. This should be address with
> > > 
> > > commit cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7
> > > Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Date:   Tue May 27 21:33:09 2014 +0300
> > > 
> > >     drm/i915: Ignore SURFLIVE and flip counter when the GPU gets reset
> > > 
> > > from -fixes. Please retest.
> > 
> > The dmesg warning still able to reproduce on latest
> > -fixes(cb4975b7c365f6d8e6d17cf4a24d846b3d27e6b7).
> 
> A lot more interesting would be knowing whether it still happens on nightly.

The failure still happens on latest -nightly(904b8529cd69f98b98d33b533a211003f99fb1cd)

root@x-bsw03:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_flip --run-subtest bcs-flip-vs-panning
IGT-Version: 1.8-gd807891 (x86_64) (Linux: 3.18.0-rc6_drm-intel-nightly_904b85_20141127+ x86_64)
Using monotonic timestamps
Beginning bcs-flip-vs-panning on crtc 8, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 8, connector 29: PASSED

Beginning bcs-flip-vs-panning on crtc 13, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..
bcs-flip-vs-panning on crtc 13, connector 29: PASSED

Subtest bcs-flip-vs-panning: SUCCESS (127.851s)
root@x-bsw03:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# dmesg -r|egrep "<[1-4]>"|grep drm
<4>[  121.367165] WARNING: CPU: 3 PID: 4326 at drivers/gpu/drm/i915/intel_display.c:3619 intel_crtc_wait_for_pending_flips+0xe7/0x1a8 [i915]()
<4>[  121.367172] Modules linked in: dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic iTCO_wdt iTCO_vendor_support snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm serio_raw pcspkr r8169 i2c_i801 lpc_ich mfd_core snd_timer option snd soundcore usb_wwan usbserial battery ac acpi_cpufreq i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
<4>[  121.367220] CPU: 3 PID: 4326 Comm: kms_flip Not tainted 3.18.0-rc6_drm-intel-nightly_904b85_20141127+ #1990
<4>[  121.367428]  [<ffffffffa0017f54>] ? drm_mode_set_config_internal+0x4e/0xd2 [drm]
<4>[  121.367446]  [<ffffffffa001bbcd>] ? drm_mode_setcrtc+0x3e9/0x48e [drm]
<4>[  121.367461]  [<ffffffffa0010738>] ? drm_ioctl+0x279/0x3bc [drm]
<4>[  121.367487]  [<ffffffffa001b7e4>] ? drm_mode_setplane+0x1e4/0x1e4 [drm]
<4>[  121.367560] WARNING: CPU: 3 PID: 4326 at drivers/gpu/drm/i915/intel_display.c:3624 intel_crtc_wait_for_pending_flips+0x121/0x1a8 [i915]()
<4>[  121.367566] Modules linked in: dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic iTCO_wdt iTCO_vendor_support snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm serio_raw pcspkr r8169 i2c_i801 lpc_ich mfd_core snd_timer option snd soundcore usb_wwan usbserial battery ac acpi_cpufreq i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
<4>[  121.367608] CPU: 3 PID: 4326 Comm: kms_flip Tainted: G        W      3.18.0-rc6_drm-intel-nightly_904b85_20141127+ #1990
<4>[  121.367798]  [<ffffffffa0017f54>] ? drm_mode_set_config_internal+0x4e/0xd2 [drm]
<4>[  121.367815]  [<ffffffffa001bbcd>] ? drm_mode_setcrtc+0x3e9/0x48e [drm]
<4>[  121.367830]  [<ffffffffa0010738>] ? drm_ioctl+0x279/0x3bc [drm]
<4>[  121.367855]  [<ffffffffa001b7e4>] ? drm_mode_setplane+0x1e4/0x1e4 [drm]
<4>[  184.346159] WARNING: CPU: 2 PID: 4326 at drivers/gpu/drm/i915/intel_display.c:3619 intel_crtc_wait_for_pending_flips+0xe7/0x1a8 [i915]()
<4>[  184.346166] Modules linked in: dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic iTCO_wdt iTCO_vendor_support snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm serio_raw pcspkr r8169 i2c_i801 lpc_ich mfd_core snd_timer option snd soundcore usb_wwan usbserial battery ac acpi_cpufreq i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
<4>[  184.346214] CPU: 2 PID: 4326 Comm: kms_flip Tainted: G        W      3.18.0-rc6_drm-intel-nightly_904b85_20141127+ #1990
<4>[  184.346423]  [<ffffffffa0017f54>] ? drm_mode_set_config_internal+0x4e/0xd2 [drm]
<4>[  184.346441]  [<ffffffffa001bbcd>] ? drm_mode_setcrtc+0x3e9/0x48e [drm]
<4>[  184.346456]  [<ffffffffa0010738>] ? drm_ioctl+0x279/0x3bc [drm]
<4>[  184.346482]  [<ffffffffa001b7e4>] ? drm_mode_setplane+0x1e4/0x1e4 [drm]
Comment 13 Ville Syrjala 2014-12-09 14:50:31 UTC
The dummy load generated by i-g-t for these tests was way too heavy for certain platforms. I fixed it so that it auto-tunes to something much more sensible.

So please re-test with latest i-g-t.
Comment 14 Guo Jinxian 2014-12-11 07:20:55 UTC
Test passes on latest -nightly(34d267c2ba9c0845432baf959a2c4deed87f3ee4) and i-g-t(b6f68c10b4ee2b730baeb8129aba36b5210ac291)

root@x-bsw01:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_flip --run-subtest bcs-flip-vs-panning
IGT-Version: 1.8-gb6f68c1 (x86_64) (Linux: 3.18.0_drm-intel-nightly_34d267_20141210+ x86_64)
Using monotonic timestamps
Beginning bcs-flip-vs-panning on crtc 8, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
........................
bcs-flip-vs-panning on crtc 8, connector 29: PASSED

Beginning bcs-flip-vs-panning on crtc 13, connector 29
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
..........................
bcs-flip-vs-panning on crtc 13, connector 29: PASSED

Subtest bcs-flip-vs-panning: SUCCESS (68.894s)
root@x-bsw01:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# dmesg -r|egrep "<[1-4]>"|grep drm
Comment 15 Jari Tahvanainen 2017-02-10 08:58:11 UTC
Closing (>2 years) old Verified+Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.