Bug 83809 - [regression] build failure after latest changes
Summary: [regression] build failure after latest changes
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: All Linux (All)
: medium normal
Assignee: Keith Packard
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-13 06:09 UTC by Fabio Pedretti
Modified: 2014-09-13 17:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
glamor: Do X server version check for fd <-> pixmap functions (1.59 KB, patch)
2014-09-13 08:14 UTC, Keith Packard
no flags Details | Splinter Review

Description Fabio Pedretti 2014-09-13 06:09:43 UTC
Intel fails to build with xorg 1.15 + glamor from git. Full log including configure options at:
https://launchpadlibrarian.net/184717024/buildlog_ubuntu-trusty-i386.xserver-xorg-video-intel_2%3A2.99.916%2Bgit1409130730.48f640~gd~t_FAILEDTOBUILD.txt.gz

Error:
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../../src/uxa -I../.. -D_FORTIFY_SOURCE=2 -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wcast-qual -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -pthread -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/mirclient -I/usr/include/libdrm -I/usr/include/mircommon -I/usr/include/xorg -I/usr/include/X11/dri -I/usr/include/libdrm -I/usr/include/libdrm -I/usr/include/libdrm -I../../../xvmc -I../../../src -I../../../src/render_program -DGLAMOR_GL -I/usr/include/xorg -I/usr/include/libdrm -I../../../xvmc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -c ../../../src/uxa/intel_glamor.c  -fPIC -DPIC -o .libs/intel_glamor.o
../../../src/uxa/intel_glamor.c: In function 'intel_glamor_pixmap_from_fd':
../../../src/uxa/intel_glamor.c:153:3: error: implicit declaration of function 'glamor_pixmap_from_fd' [-Werror=implicit-function-declaration]
   return glamor_pixmap_from_fd(screen, fd, width, height, stride, depth, bpp);
   ^
../../../src/uxa/intel_glamor.c:153:3: warning: nested extern declaration of 'glamor_pixmap_from_fd' [-Wnested-externs]
../../../src/uxa/intel_glamor.c:153:3: warning: return makes pointer from integer without a cast [enabled by default]
../../../src/uxa/intel_glamor.c: In function 'intel_glamor_fd_from_pixmap':
../../../src/uxa/intel_glamor.c:166:17: error: implicit declaration of function 'glamor_fd_from_pixmap' [-Werror=implicit-function-declaration]
                 return glamor_fd_from_pixmap(screen, pixmap, stride, size);
                 ^
../../../src/uxa/intel_glamor.c:166:17: warning: nested extern declaration of 'glamor_fd_from_pixmap' [-Wnested-externs]
cc1: some warnings being treated as errors
make[4]: *** [intel_glamor.lo] Error 1
Comment 1 Chris Wilson 2014-09-13 06:43:09 UTC
What? That's not even our code.
Comment 2 Keith Packard 2014-09-13 08:14:09 UTC
Created attachment 106206 [details] [review]
glamor: Do X server version check for fd <-> pixmap functions

Please see if this patch makes it work; it disables the glamor DRI3 hooks when compiled against an older X server.
Comment 3 Fabio Pedretti 2014-09-13 17:46:44 UTC
Yes, the patch fixes the build error. I notice now some warnings like:
../../../src/uxa/intel_video.c:93:3: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
   "XV_IMAGE",
   ^
but probably are unrelated to latest changes.

Build log with patch applied here:
https://launchpadlibrarian.net/184755906/buildlog_ubuntu-trusty-i386.xserver-xorg-video-intel_2%3A2.99.916%2Bgit1409131931.48f640~gd~t_UPLOADING.txt.gz
Comment 4 Keith Packard 2014-09-13 17:55:54 UTC
Thanks for testing the patch. The other warnings are due to bugs in the X server version you're using and are not a problem.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.