Created attachment 106375 [details] Fix According to GLSL(4.2) and GLSL-ES (1.0, 3.0) spec, Structures must have the same name to be considered same type. From GLSL 4.20 specification: (Sec 4.2) "Structures must have the same name, sequence of type names, and type definitions, and field names to be considered the same type. " GLSL-ES is also same(Ver 1.00 Sec 4.2.4, Ver 3.00 Sec 4.2.5). We currently ignore the name while checking if two records are same. The following WebGL conformance tests fail when running Chromium Web Browser with Wayland(https://github.com/01org/ozone-wayland) Test case: https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shaders-with-uniform-structs.html Attached is patch which fixes this.
Note: This fixes "Structures must have the same name to be considered the same type." test case from https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shaders-with-uniform-structs.html
The patch will need some additional changes as it will break usecases with unnamed types (which are assigned a name automatically by Mesa), will see what would fix this.
Created attachment 106670 [details] [review] fix Modified version of the patch that takes care of the 'anonymous structures' issue mentioned. Will do some testing to verify that this is the right thing todo.
fixed in master
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.