Bug 83979 - xdg-utils-common is broken, xdg-open uses bashism
Summary: xdg-utils-common is broken, xdg-open uses bashism
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.1.0 rc3
Hardware: All Linux (All)
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-17 11:21 UTC by rkfg
Modified: 2014-09-17 11:32 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch for xdg-utils (753 bytes, text/plain)
2014-09-17 11:21 UTC, rkfg
Details

Description rkfg 2014-09-17 11:21:27 UTC
Created attachment 106423 [details]
patch for xdg-utils

The latest commit 781023ef997bac433dbc258bd5cfdc1366f2ffa4 not only bumps the version but also adds a "t" letter breaking syntax. xdg-open uses bashism for years (introduced in commit ba265f969b9061d221915c2528122c44a85ad7c2) and it breaks multigroup desktop files, actually (easily verified with Google Chrome, sed shows an error because 'localised_name' var receives 3 lines and thus the sed command isn't terminated properly). One of the cases there is [*), and while it works in bash, dash uses “[” as a meta-character. I've quoted it to make it work.
Comment 1 Rex Dieter 2014-09-17 11:32:29 UTC
Thanks, patch applied.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.