Bug 84030 - Update and Overhaul the Visual Studio 2008 and 2010 Projects
Summary: Update and Overhaul the Visual Studio 2008 and 2010 Projects
Status: RESOLVED FIXED
Alias: None
Product: cairomm
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: Other Windows (All)
: medium normal
Assignee: Murray Cumming
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-18 08:46 UTC by Fan, Chun-wei
Modified: 2015-08-22 01:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Update and Overhaul the Visual Studio 2008 Projects (135.08 KB, patch)
2014-09-18 08:51 UTC, Fan, Chun-wei
Details | Splinter Review
Overhaul the Visual Studio 2010 Projects (237.94 KB, patch)
2014-09-18 09:11 UTC, Fan, Chun-wei
Details | Splinter Review

Description Fan, Chun-wei 2014-09-18 08:46:59 UTC
Hi,

The Visual Studio 2008 projects have gotten a bit out of date, and I thought it might be good that we overhaul it a bit as there are many items which IMHO can be consolidated into property sheets, so that future maintenance of these items can be eased a bit.

For the Visual Studio 2010 projects, although David updated it not too long ago, I thought it might be also good to give it a makeover with the property sheets treatment as well.

I will attach patches for these in a bit...
Comment 1 Fan, Chun-wei 2014-09-18 08:51:13 UTC
Created attachment 106485 [details] [review]
Update and Overhaul the Visual Studio 2008 Projects

Hi,

This is my take at updating and overhauling the Visual Studio 2008 projects, using property sheets to consolidate items and purging unneeded entries of the project files.  The cairomm project has also been updated, so that all the needed sources are included in the build...
Comment 2 Fan, Chun-wei 2014-09-18 09:11:31 UTC
Created attachment 106489 [details] [review]
Overhaul the Visual Studio 2010 Projects

Hi,

This updates the Visual Studio 2010 projects like what was done for the Visual Studio 2008 projects, and adds a PlatformToolset tag so that we can support Visual Studio 2012/2013 easier (such as using a script, as in the GLib Visual Studio project files) as the project file formats for Visual Studio 2010/2012/2013 are largely similar.

With blessings, thank you!
Comment 3 Murray Cumming 2015-08-20 18:29:09 UTC
I have pushed both patches. Sorry for not noticing this sooner. Many thanks.
Comment 4 Murray Cumming 2015-08-20 19:12:52 UTC
However, I now see this build error:

make[2]: Entering directory '/home/murrayc/checkout/gnome/cairomm'
make[2]: *** No rule to make target 'MSVC_Net2010/cairo-build-defines.props', needed by 'all-am'.  Stop.
make[2]: Leaving directory '/home/murrayc/checkout/gnome/cairomm'
Makefile:669: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
ma

Maybe the .props file was missing from the patch?
Comment 5 Murray Cumming 2015-08-21 15:59:02 UTC
Hopefully this was the appropriate fix:
http://cgit.freedesktop.org/cairomm/commit/?id=b7ac2d8ee45571bdc7bee5b656c61dcb26084421
Comment 6 Fan, Chun-wei 2015-08-22 01:34:00 UTC
Hi Murray,

Sorry, I also forgot about this patchset that I did for this.  Apparently that is the correct fix.

However, since we are now using C++-11 for cairomm, it seems that the Visual Studio 2008 files will need to be dropped, and it will be at least Visual Studio 2012 (more likely 2013) that is going to required to build cairomm (and the gtkmm (C++) stack), but I think this will belong to another bug, if you prefer.

With blessings, thank you!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.