Bug 84033 - Check for CAIRO_HAS_FC_FONT
Summary: Check for CAIRO_HAS_FC_FONT
Status: RESOLVED FIXED
Alias: None
Product: cairomm
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Murray Cumming
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-18 09:16 UTC by Fan, Chun-wei
Modified: 2015-08-20 18:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fontface/fontoption: Check for whether Cairo was built with FontConfig (3.52 KB, patch)
2014-09-18 09:23 UTC, Fan, Chun-wei
Details | Splinter Review

Description Fan, Chun-wei 2014-09-18 09:16:59 UTC
Hi,

In the fontface and fontoptions sources, there are checks for whether Cairo was built with FreeType support (CAIRO_HAS_FT_FONT), however, in Cairo 1.12 (at least), Cairo can be built with FreeType support with or without FontConfig support (which is checked by CAIRO_HAS_FC_FONT).  So, if one builds cairomm against Cairo that has FreeType support enabled but without FontConfig support enabled (for example, on Windows builds), the build would fail.

I will attach patches to have the sources/headers check for whether Cairo had FontConfig support so that this kind of situation can be supported...
Comment 1 Fan, Chun-wei 2014-09-18 09:23:48 UTC
Created attachment 106491 [details] [review]
fontface/fontoption: Check for whether Cairo was built with FontConfig

Hi,

This patch updates the fontface/fontoption sources and headers so that they will also check whether Cairo was built with Fontconfig in addition to checking for FreeType.

With blessings, thank you!
Comment 2 Murray Cumming 2015-08-20 18:27:47 UTC
Sorry for not noticing this for so long. I've pushed this now. Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.