Bug 84120 - X11 overestimates unbounded operations affected area -> set FORCE_CLIP_REGION
Summary: X11 overestimates unbounded operations affected area -> set FORCE_CLIP_REGION
Alias: None
Product: cairo
Classification: Unclassified
Component: xlib backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Chris Wilson
QA Contact: cairo-bugs mailing list
Depends on:
Reported: 2014-09-20 12:59 UTC by Massimo
Modified: 2018-08-25 13:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

proposed patch (1.11 KB, text/plain)
2014-09-20 12:59 UTC, Massimo
combined patch (2.20 KB, text/plain)
2014-09-22 13:37 UTC, Massimo
combined patch (2.20 KB, patch)
2014-09-23 10:36 UTC, Massimo
Details | Splinter Review

Description Massimo 2014-09-20 12:59:36 UTC
Created attachment 106578 [details]
proposed patch

Before calling clip_and_composite, setting the flag FORCE_CLIP_REGION
when !extents->is_bounded in clip_and_composite_boxes,
as it is already done in clip_and_composite_polygon and
clip_and_composite_traps, fixes overlapping-boxes.xlib.rgb24 and
visibly improves tighten-bounds.xlib.argb32.
Comment 1 Massimo 2014-09-22 13:37:20 UTC
Created attachment 106678 [details]
combined patch

Apparently also the xcb backend does not always consider X11's overestimation
of the affected area for unbounded operators.

The fix is similar to that for xlib.
Comment 2 Massimo 2014-09-23 10:36:44 UTC
Created attachment 106720 [details] [review]
combined patch

while refactoring the previous patch I inverted the ? : branches after
having run make test, fixed in the patch attached to this report.
Comment 3 GitLab Migration User 2018-08-25 13:51:04 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/cairo/cairo/issues/230.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.