Bug 84124 - Please revert 8449121971ce1db03fea19665d314e523fdc10dd
Summary: Please revert 8449121971ce1db03fea19665d314e523fdc10dd
Status: RESOLVED WONTFIX
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Marek Olšák
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-20 20:30 UTC by almos
Modified: 2014-12-11 14:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description almos 2014-09-20 20:30:20 UTC
Using one of those environment variables was the only way of getting MSAA in older games. If some users don't understand what these environment variables do, it's a problem with the documentation, and the developers shouldn't punish those users who do understand.
Comment 1 Marek Olšák 2014-09-21 21:37:14 UTC
You can revert the commit locally if you want. Sorry, I cannot let a medium like Phoronix abuse it, break apps and then telling people that our driver is broken.
Comment 2 almos 2014-09-22 21:28:52 UTC
Have you tried to talk to Phoronix about this issue? I don't think Michael is deliberately going full retard, he's just underinformed about lots of things.
Comment 3 Marek Olšák 2014-09-28 18:46:48 UTC
This may be revisited in the future. For now, the commit won't be reverted. I don't think a documentation would help in any way. The implementation of the GALLIUM_MSAA environment variable must be foolproof and it wasn't.

Please don't take it personally. I care about our users very much, but some users are not as smart as you and I'd like them not to fall into a trap.
Comment 4 almos 2014-10-08 22:46:28 UTC
I've been thinking a bit about this, and I'd like to ask for an entry in the release notes about this feature change. I hope that will increase the chance that someone will eventually start working on a better implementation.

A question that is somewhat related: is it possible to automatically do alpha-to-coverage for alpha-tested surfaces? When using __GL_FSAA_MODE on old games it was quite noticeable that railings and fences were not antialiased.
Comment 5 Marek Olšák 2014-10-09 12:55:11 UTC
(In reply to almos from comment #4)
> I've been thinking a bit about this, and I'd like to ask for an entry in the
> release notes about this feature change. I hope that will increase the
> chance that someone will eventually start working on a better implementation.

Will do.

> 
> A question that is somewhat related: is it possible to automatically do
> alpha-to-coverage for alpha-tested surfaces? When using __GL_FSAA_MODE on
> old games it was quite noticeable that railings and fences were not
> antialiased.

Yes, but it needs to be supported explicitly by st/mesa.
Comment 6 almos 2014-11-15 23:16:30 UTC
I noticed that 10.4 has recently been branched, but the release notes doesn't mention this change yet.
Comment 7 Emil Velikov 2014-12-11 14:08:39 UTC
commit ac319d94d38cf3145990002c8216426fe297cd28
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Wed Dec 10 19:59:53 2014 +0100

    docs/relnotes: document the removal of GALLIUM_MSAA

    Cc: 10.2.10.3 10.4 <mesa-stable@lists.freedesktop.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.