Bug 84130 - Modifications to registry.h cause compilation of dispatch.c
Summary: Modifications to registry.h cause compilation of dispatch.c
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium blocker
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-21 05:05 UTC by Bob Gleitsmann
Modified: 2014-09-22 22:12 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Bob Gleitsmann 2014-09-21 05:05:27 UTC 
Commit 	69d8572ae4cd1bce17223ea8aff87916a974c861, "Build required portions of registry.c automatically [v2]" deletes definition of LookupMajorName. However, this function is used in dispatch.c around line 421. The code is surrounded by conditional on XSERVER_DTRACE, but not X_REGISTRY_REQUEST. Presumably the registry is not used unless XSELINUX or XCSECURITY is set. Xorg compiles if the code in code bracketed by the XSERVER_DTRACE is conditioned on X_REGISTRY_REQUEST. But I am only guessing that this is appropriate. 
Please fix this.

Best Wishes,

Bob Gleitsmann
Comment 1 Bob Gleitsmann 2014-09-21 05:09:50 UTC 
Third from last sentence should read: "Xorg compiles if the code bracketed by the XSERVER_DTRACE #ifdef is also #ifdef'd on X_REGISTRY_REQUEST."
Comment 2 Alan Coopersmith 2014-09-21 16:31:45 UTC 
Fix already submitted to xorg-devel:
http://patchwork.freedesktop.org/patch/33750/
Comment 3 Bob Gleitsmann 2014-09-21 17:50:57 UTC 
Yes, the referenced patch solves the problem. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.