==System Environment== -------------------------- Regression: Yes. Non-working platforms: BDW ==kernel== -------------------------- origin/drm-intel-nightly: ea4bec8e96ea8b33b49a7892c1c7f20041a56da6(fails) drm-intel-nightly: 2014y-10m-09d-07h-58m-45s UTC integration manifest ==Bug detailed description== igt/kms_rotation_crc/sprite-rotation causes "WARNING: CPU: 0 PID: 18663 at drivers/gpu/drm/i915/intel_display.c:1238 assert_plane.constprop.50+0x5f/0x62 [i915]()" Dmesg: [ 899.710469] WARNING: CPU: 0 PID: 18663 at drivers/gpu/drm/i915/intel_display.c:1238 assert_plane.constprop.50+0x5f/0x62 [i915]() [ 899.850921] plane A assertion failure (expected on, current off) [ 899.923845] Modules linked in: ip6table_filter ip6_tables iptable_filter ip_tables ebtable_nat ebtables x_tables ipv6 dm_mod iTCO_wdt iTCO_vendor_support ppdev snd_hda_codec_hdmi snd_hda_intel snd_hda_controller pcspkr snd_hda_codec snd_hwdep snd_pcm snd_timer i2c_i801 lpc_ich snd mfd_core soundcore battery parport_pc parport ac acpi_cpufreq i915 button video drm_kms_helper drm [ 900.334222] CPU: 0 PID: 18663 Comm: kms_rotation_cr Not tainted 3.17.0_prts_ff1ea7_20141009_debug+ #70 [ 900.447236] 0000000000000000 ffff880003023a68 ffffffff8181355c ffff880003023ab0 [ 900.537487] ffff880003023aa0 ffffffff8103e87f ffffffffa00cd779 0000000000000000 [ 900.627753] ffff88014923b000 ffff88014902f000 0000000000000000 ffff880003023b00 [ 900.718014] Call Trace: [ 900.747684] [] dump_stack+0x45/0x56 [ 900.810057] [] warn_slowpath_common+0x7f/0x98 [ 900.883011] [] ? assert_plane.constprop.50+0x5f/0x62 [i915] [ 900.970704] [] warn_slowpath_fmt+0x4c/0x4e [ 901.040499] [] assert_plane.constprop.50+0x5f/0x62 [i915] [ 901.126107] [] hsw_disable_ips+0x35/0x15c [i915] [ 901.202224] [] intel_crtc_disable_planes+0x49/0xe9 [i915] [ 901.287832] [] haswell_crtc_disable+0x38/0x283 [i915] [ 901.369224] [] __intel_set_mode+0x791/0x1230 [i915] [ 901.448503] [] intel_set_mode+0x14/0x2a [i915] [ 901.522512] [] intel_crtc_set_config+0x9b6/0xa9f [i915] [ 901.606000] [] ? drm_modeset_lock+0x8f/0xb1 [drm] [ 901.683161] [] drm_mode_set_config_internal+0x55/0xe0 [drm] [ 901.770879] [] drm_framebuffer_remove+0x8e/0x106 [drm] [ 901.853319] [] drm_mode_rmfb+0xcf/0xfa [drm] [ 901.925198] [] drm_ioctl+0x385/0x404 [drm] [ 901.994974] [] ? drm_mode_addfb2+0x32/0x32 [drm] [ 902.071061] [] ? mntput_no_expire+0x5/0x1af [ 902.141878] [] ? mntput_no_expire+0x5a/0x1af [ 902.213744] [] ? mntput_no_expire+0x5/0x1af [ 902.284558] [] do_vfs_ioctl+0x3a3/0x46c [ 902.351151] [] ? current_kernel_time+0x61/0x9a [ 902.425131] [] ? trace_hardirqs_on_caller+0x16e/0x18a [ 902.506493] [] SyS_ioctl+0x50/0x7d [ 902.567812] [] system_call_fastpath+0x16/0x1b [ 902.640733] ---[ end trace a7cf4328bfdc1cbf ]---", ==Reproduce steps== ---------------------------- 1. ./kms_rotation_crc --run-subtest sprite-rotation ==Bisect results from PRTS== ---------------------------- Bisect shows: 1180e20606fd7c5d76dc5b2a1594fa51ba5a0f31 is the first bad commit commit 1180e20606fd7c5d76dc5b2a1594fa51ba5a0f31 Author: Paulo Zanoni <paulo.r.zanoni@intel.com> AuthorDate: Tue Oct 7 18:02:52 2014 -0300 Commit: Jani Nikula <jani.nikula@intel.com> CommitDate: Wed Oct 8 16:47:54 2014 +0300 drm/i915: properly reenable gen8 pipe IRQs We were missing the pipe B/C vblank bits! Take a look at gen8_de_irq_postinstall for a comparison. This should fix a bunch of IGT tests. There are a few more things we could improve on this code, but this should be the minimal fix to unblock us. v2: s/extra_iir/extra_ier/ because IIR doesn't make sense (Ville) Bugzilla:https://bugs.freedesktop.org/show_bug.cgi?id=83640 Testcase: igt/* Cc: stable@vger.kernel.org Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
The "bad commit" is not a regression, it is actually the commit which converted this test from FAIL to PASS: without it, we were getting a FAIL, and a lot of dmesg WARNs. Now, we get a SUCCESS with a single Kernel WARN. Why are you considering that specific commit, the "bad commit"?
(In reply to Paulo Zanoni from comment #1) > The "bad commit" is not a regression, it is actually the commit which > converted this test from FAIL to PASS: without it, we were getting a FAIL, > and a lot of dmesg WARNs. Now, we get a SUCCESS with a single Kernel WARN. > > Why are you considering that specific commit, the "bad commit"? Yes, this patch fixed a bug, but it involved a new bug(dmesg WARN) at the same time. This bug was reported to track the dmesg WARN.
As Paulo explained not a regression, just a bug.
Please attach full drm.debug=0xe logs up to the backtrace.
The failure unable to reproduce on latest -nightly(cf3d262e39941d8f148148e840c00fcbc35a8e6f), another dmesg warning "WARNING: CPU: 0 PID: 4674 at drivers/gpu/drm/i915/intel_display.c:1256 hsw_enable_ips+0x38/0x13b [i915]()" occurs, which tracked by bug 86370
Closing old verified.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.