Bug 85079 - [all Bisected]Piglit ImportError: No module named exectest
Summary: [all Bisected]Piglit ImportError: No module named exectest
Status: VERIFIED FIXED
Alias: None
Product: piglit
Classification: Unclassified
Component: infrastructure (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high critical
Assignee: Dylan Baker
QA Contact: Eric Anholt
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-16 02:44 UTC by lu hua
Modified: 2014-10-30 02:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
A small patch used to fix this issue (482 bytes, patch)
2014-10-27 08:40 UTC, shuo.wang
Details | Splinter Review

Description lu hua 2014-10-16 02:44:05 UTC
==System Environment==
--------------------------
Piglit: 534e6a8585ae6bd41148014d8d68c9018d7f94e4
Libdrm:		(master)libdrm-2.4.58-4-g00847fa48b83a85b0cb882594a12ed1511f780db
Mesa:		(master)8cf6482c3da9493dacf4a6a495ae3c0193cf75a7
Xserver:	(master)xorg-server-1.16.0-418-g61a292adf45405641de1c522a04c148e0a152acd
Xf86_video_intel:(master)2.99.916-98-g49cf2803d3bc3be12f6a59581631fdf5547bb0e3
Libva:		(master)ccd93de5a707e92a629cccd595757c8d436fa3cc
Libva_intel_driver:(master)f11176415ec26eb5960ba6841d2d9c22f2cabc60
Kernel:   (drm-intel-nightly)2ea23cd593ba60ead60e2f796fae675aa4475b1a

==Bug detailed description==
-----------------------------
Run piglit case report:
Traceback (most recent call last):
  File "./piglit-print-commands.py", line 34, in <module>
    from framework.exectest import Test
ImportError: No module named exectest
test thread complete

Bisect shows: 3d00e91606e06b1c74a3d479176f6ddc0de19db2 is the first bad commit
commit 3d00e91606e06b1c74a3d479176f6ddc0de19db2
Author:     Dylan Baker <dylanx.c.baker@intel.com>
AuthorDate: Wed Sep 10 10:21:25 2014 -0700
Commit:     Dylan Baker <dylanx.c.baker@intel.com>
CommitDate: Tue Oct 14 14:33:03 2014 -0700

    framework: Move tests derived classes into a package

    This moves all of the classes that derive from Test into a package
    called test. This patch looks very large, but is mostly just moving
    files around and changing imports to account for this.

    So why all of this code churn? The big advantage is that through
    __init__.py magic there is one module to be imported, framework.test.
    This module contains all of the public classes, functions, and
    constants, in one place while hiding the rest, but allowing them to be
    accessed explicitly.

    Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>

==Reproduce steps==
---------------------------- 
1. Run all Piglit cases
Comment 1 shuo.wang 2014-10-27 08:40:34 UTC
Created attachment 108494 [details] [review]
A small patch used to fix this issue

I just modify the piglit test as attachment, then it can be worked.
Comment 2 Dylan Baker 2014-10-27 20:15:02 UTC
Your patch looks correct. It could be simplified a little bit, and I've sent a slightly tweaked version to the list.

http://patchwork.freedesktop.org/patch/35716/
Comment 3 lu hua 2014-10-28 02:09:39 UTC
(In reply to Dylan from comment #2)
> Your patch looks correct. It could be simplified a little bit, and I've sent
> a slightly tweaked version to the list.
> 
> http://patchwork.freedesktop.org/patch/35716/

Fixed by this patch.
Comment 4 Dylan Baker 2014-10-29 02:28:44 UTC
Fixed

To ssh://git.fdo/git/piglit
   05cd842..3c68657  master -> master
Comment 5 lu hua 2014-10-30 02:09:40 UTC
Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.