Bug 85277 - [i386 Bisected]system boot fail
Summary: [i386 Bisected]system boot fail
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: highest blocker
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL: https://lkml.org/lkml/2014/10/22/667
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 07:02 UTC by lu hua
Modified: 2017-02-10 08:54 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Revert patch (5.43 KB, patch)
2014-10-21 19:10 UTC, Paulo Zanoni
no flags Details | Splinter Review

Description lu hua 2014-10-21 07:02:46 UTC
==System Environment==
--------------------------
Regression: Yes 
 good commit:bfe01a5ba2490f299e1d2d5508cbbbadd897bbe9
 bad commit: f114040e3ea6e07372334ade75d1ee0775c355e1

Non-working platforms: PNV/ILK/SNB i386 arch

==kernel==
--------------------------
drm-intel-fixes/f114040e3ea6e07372334ade75d1ee0775c355e1

==Bug detailed description==
-----------------------------
System boot fail on PNV/ILK/SNB i386 arch.
It happens on -nightly kernel and -fixes kernel. It works well on -queued kernel.

Bisect is in process. 

==Reproduce steps==
---------------------------- 
1. clean boot system
Comment 1 lu hua 2014-10-21 08:25:53 UTC
Bisect shows: b4f0d3755c5e9cc86292d5fd78261903b4f23d4a is the first bad commit.
commit b4f0d3755c5e9cc86292d5fd78261903b4f23d4a
Author:     Richard Guy Briggs <rgb@redhat.com>
AuthorDate: Tue Mar 4 10:38:06 2014 -0500
Commit:     Eric Paris <eparis@redhat.com>
CommitDate: Tue Sep 23 16:21:28 2014 -0400

    audit: x86: drop arch from __audit_syscall_entry() interface

    Since the arch is found locally in __audit_syscall_entry(), there is no need
    pass it in as a parameter.  Delete it from the parameter list.

    x86* was the only arch to call __audit_syscall_entry() directly and did so f
    assembly code.

    Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: x86@kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: linux-audit@redhat.com
    Signed-off-by: Eric Paris <eparis@redhat.com>

    ---

    As this patch relies on changes in the audit tree, I think it
    appropriate to send it through my tree rather than the x86 tree.
Comment 2 Paulo Zanoni 2014-10-21 19:10:28 UTC
Created attachment 108205 [details] [review]
Revert patch

Can you please confirm that this patch makes your system work again?
Comment 3 lu hua 2014-10-22 05:17:03 UTC
(In reply to Paulo Zanoni from comment #2)
> Created attachment 108205 [details] [review] [review]
> Revert patch
> 
> Can you please confirm that this patch makes your system work again?

Yes, apply it, system boot successfully.
Comment 4 Paulo Zanoni 2014-10-24 17:30:57 UTC
Issue reported upstream through LKML: https://lkml.org/lkml/2014/10/22/667
Comment 5 Paulo Zanoni 2014-10-27 16:29:02 UTC
Should be solved by "i386/audit: stop scribbling on the stack frame", which at some point in the future will land on Linus' tree, from the x86/urgent branch, then will get merged by Daniel.
Comment 6 Yi Sun 2014-10-28 01:25:12 UTC
Sorry, change status back to assigned. We can change it until the related patch in Daniel's repo.
Comment 7 Paulo Zanoni 2014-11-03 13:44:40 UTC
(In reply to Paulo Zanoni from comment #5)
> Should be solved by "i386/audit: stop scribbling on the stack frame", which
> at some point in the future will land on Linus' tree, from the x86/urgent
> branch, then will get merged by Daniel.

Patch is already on drm-intel-fixes. Closing bug. If it still happens, please reopen.
Comment 8 Jani Nikula 2014-11-03 16:08:55 UTC
Fix is already in v3.18-rc1

commit 26c2d2b39128adba276d140eefa2745591b88536
Author: Eric Paris <eparis@redhat.com>
Date:   Thu Oct 23 00:04:03 2014 -0400

    i386/audit: stop scribbling on the stack frame
Comment 9 lu hua 2014-11-04 06:41:21 UTC
Fixed on latest -fixes kernel.
Comment 10 Jari Tahvanainen 2017-02-10 08:54:18 UTC
Closing (>2 years) old Verified+Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.