Bug 85287 - Use default compose key with Finnish keyboard
Summary: Use default compose key with Finnish keyboard
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 12:21 UTC by Marko Myllynen
Modified: 2018-01-18 20:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Use default compose key with Finnish keyboard (1004 bytes, patch)
2014-10-21 12:21 UTC, Marko Myllynen
Details | Splinter Review

Description Marko Myllynen 2014-10-21 12:21:05 UTC
Created attachment 108167 [details] [review]
Use default compose key with Finnish keyboard

Currently fi(default) and fi(classic) use rwin as the Compose key but rwin is missing from many laptops (e.g., Acer, HP, Lenovo) and the SFS 5966 standard doesn't specify what the Compose key should actually be.

I also checked with Troy who sent the patch which introduced it and he can't remember the background for it so we agreed that it's best to go with the default now.
Comment 1 Marko Myllynen 2017-11-06 10:51:51 UTC
It's been over three years with this, how could we proceed here? Thanks.
Comment 2 Olivier Fourdan 2017-11-06 13:10:06 UTC
(In reply to Marko Myllynen from comment #1)
> It's been over three years with this, how could we proceed here? Thanks.

Patches should be sent to the ML for review, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches/
Comment 3 Marko Myllynen 2017-11-06 13:18:34 UTC
Hmm, let's start by fixing the Product/Component..
Comment 4 Sergey V. Udaltsov 2018-01-18 19:19:40 UTC
Your patch unfortunately did not work with git, I did it manually. Please check. Thank you!
Comment 5 Marko Myllynen 2018-01-18 19:25:14 UTC
(In reply to Sergey V. Udaltsov from comment #4)
> Your patch unfortunately did not work with git, I did it manually.

You forgot to remove the latter definition, currently on line 280, could you drop it as well while at it? I can create a patch as well if you want but might be quicker you just adjust it manually. Thanks.
Comment 6 Sergey V. Udaltsov 2018-01-18 20:55:27 UTC
thank you, fixed!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.