Bug 85975 - mac_selinux_access_check() used in method_disable_unit_files_generic()
Summary: mac_selinux_access_check() used in method_disable_unit_files_generic()
Status: RESOLVED NOTABUG
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 17:28 UTC by Laurent Bigonville
Modified: 2014-11-06 23:57 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Laurent Bigonville 2014-11-06 17:28:33 UTC
Hello,

In method_enable_unit_files_generic(), mac_selinux_unit_access_check_strv() is used to check the SELinux permissions while in method_disable_unit_files_generic(), mac_selinux_access_check() is used.

Shouldn't it be mac_selinux_unit_access_check_strv() in both cases as it applies to units and that you can have a list of them?

Am I missing something here?
Comment 1 Lennart Poettering 2014-11-06 23:57:14 UTC
See my reply on the ML.

http://lists.freedesktop.org/archives/systemd-devel/2014-November/024995.html

Nothing to fix really, SELInux is just weird.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.