Bug 8607 - introspection crashes when object has properties
Summary: introspection crashes when object has properties
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Robert McQueen
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
: 7057 11233 12461 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-10-11 12:53 UTC by william.jon.mccann
Modified: 2007-10-24 20:44 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
patch (909 bytes, patch)
2006-10-11 12:54 UTC, william.jon.mccann
Details | Splinter Review
additional patch (610 bytes, patch)
2007-03-09 11:08 UTC, william.jon.mccann
Details | Splinter Review

Description william.jon.mccann 2006-10-11 12:53:34 UTC
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1208330560 (LWP 5209)]
write_interface (key=0x804f320, val=0x859ac80, user_data=0xbfdaa3c4) at
dbus-gobject.c:456
456           s = _dbus_gutils_wincaps_to_uscore (spec->name);
(gdb) bt
#0  write_interface (key=0x804f320, val=0x859ac80, user_data=0xbfdaa3c4) at
dbus-gobject.c:456
#1  0x004ff826 in IA__g_hash_table_foreach (hash_table=0x85956a0, func=0x2323f0
<write_interface>, 
    user_data=0xbfdaa3c4) at ghash.c:662
#2  0x00232e2f in handle_introspect (connection=0x85973f8, message=0x85977c8,
object=0x859b460) at dbus-gobject.c:583
#3  0x00235014 in gobject_message_function (connection=0x85973f8,
message=0x85977c8, user_data=0x859b460)
    at dbus-gobject.c:1296
#4  0x006be019 in _dbus_object_tree_dispatch_and_unlock (tree=0x8597258,
message=0x85977c8) at dbus-object-tree.c:842
#5  0x006a884c in dbus_connection_dispatch (connection=0x85973f8) at
dbus-connection.c:3820
#6  0x002312ad in message_queue_dispatch (source=0x8598dd0, callback=0,
user_data=0x0) at dbus-gmain.c:101
#7  0x0050c602 in IA__g_main_context_dispatch (context=0x8598d50) at gmain.c:2045
#8  0x0050f5cf in g_main_context_iterate (context=0x8598d50, block=1,
dispatch=1, self=0x8592ca0) at gmain.c:2677
#9  0x0050f979 in IA__g_main_loop_run (loop=0x859c538) at gmain.c:2881
#10 0x0804a3b4 in main (argc=1, argv=0xbfdaa9b4) at main.c:124
Comment 1 william.jon.mccann 2006-10-11 12:54:11 UTC
Created attachment 7359 [details] [review]
patch

Also fixes a double free.
Comment 2 Rob Taylor 2006-10-25 11:38:03 UTC
Fixed in 0.72.
Thanks for the patch!
Comment 3 Rob Taylor 2006-10-25 12:52:58 UTC
*** Bug 7057 has been marked as a duplicate of this bug. ***
Comment 4 william.jon.mccann 2007-03-09 11:04:37 UTC
Jonathan's patch in the other bug was more complete.  We still have a spurious closing tag...

    <property name="session-type" type="s" access="readwrite"/>
    </property>
Comment 5 william.jon.mccann 2007-03-09 11:08:51 UTC
Created attachment 9057 [details] [review]
additional patch

This closing tag shouldn't be used because the first tag is self-terminated.
Comment 6 Ross Burton 2007-09-11 02:37:58 UTC
Committed to git, thanks.
Comment 7 Ross Burton 2007-09-11 02:38:53 UTC
*** Bug 11233 has been marked as a duplicate of this bug. ***
Comment 8 Ben Gamari 2007-10-24 20:44:41 UTC
*** Bug 12461 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.