Bug 86361 - [Bisected]Piglit compile-program.c make fail
Summary: [Bisected]Piglit compile-program.c make fail
Status: CLOSED FIXED
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high critical
Assignee: Piglit Mailing List
QA Contact: Piglit Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-17 02:28 UTC by lu hua
Modified: 2015-02-06 11:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fix clCompileProgram with CL1.1 headers (1.17 KB, patch)
2014-11-26 13:21 UTC, Serge Martin
Details | Splinter Review

Description lu hua 2014-11-17 02:28:02 UTC
System Environment:
--------------------------
Platform: all
Piglit dccf0e3a15377f382a7b50ac52031e1a0a0330a9

Bug detailed description:
---------------------------
Piglit build fail due to the following patch.

Bisect shows: a373287ce0b7ae0c6825508441aaab412693b443 is the first bad commit.
commit a373287ce0b7ae0c6825508441aaab412693b443
Author:     EdB <edb+piglit@sigluy.net>
AuthorDate: Fri Nov 7 16:24:27 2014 +0100
Commit:     Tom Stellard <thomas.stellard@amd.com>
CommitDate: Fri Nov 14 20:30:33 2014 -0500

    cl: add tests for clCompileProgram

    v2:
    Use clBuildProgram to create to program to attach kernel to

build log:
[ 95%] Building C object target_api/cl/tests/cl/api/CMakeFiles/cl-api-compile-program.dir/compile-program.c.o
In file included from /opt/X11R7/include/CL/opencl.h:44:0,
                 from /GFX/Test/Piglit/piglit/tests/util/piglit-util-cl-enum.h:31,
                 from /GFX/Test/Piglit/piglit/tests/util/piglit-util-cl.h:29,
                 from /GFX/Test/Piglit/piglit/tests/util/piglit-framework-cl.h:28,
                 from /GFX/Test/Piglit/piglit/tests/util/piglit-framework-cl-api.h:28,
                 from /GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c:40:
/opt/X11R7/include/CL/cl_gl_ext.h:44:4: warning: "/*" within comment [-Wcomment]
  * /* cl_VEN_extname extension  */
 ^
/GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c: In function ‘test’:
/GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c:84:2: warning: implicit declaration of function ‘clCompileProgram’ [-Wimplicit-function-declaration]
  errNo = clCompileProgram(program,
  ^
/GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c: In function ‘piglit_cl_test’:
/GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c:239:7: error: ‘CL_INVALID_COMPILER_OPTIONS’ undeclared (first use in this function)
       CL_INVALID_COMPILER_OPTIONS, &result,
       ^
/GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c:239:7: note: each undeclared identifier is reported only once for each function it appears in
/GFX/Test/Piglit/piglit/tests/cl/api/compile-program.c:289:8: error: ‘CL_COMPILE_PROGRAM_FAILURE’ undeclared (first use in this function)
        CL_COMPILE_PROGRAM_FAILURE, &result,
        ^
make[2]: *** [target_api/cl/tests/cl/api/CMakeFiles/cl-api-compile-program.dir/compile-program.c.o] Error 1
make[1]: *** [target_api/cl/tests/cl/api/CMakeFiles/cl-api-compile-program.dir/all] Error 2
make: *** [all] Error 2
Comment 1 Serge Martin 2014-11-26 13:21:04 UTC
Created attachment 110060 [details] [review]
fix clCompileProgram with CL1.1 headers

Hello

If you need to stick with OpenCL 1.1 headers, please try this patch.

Best regards
Comment 2 lu hua 2014-11-27 06:08:05 UTC
It works well again.
Comment 3 lu hua 2014-11-27 06:08:18 UTC
Verified.Fixed.
Comment 4 Serge Martin 2015-02-06 11:39:44 UTC
pushed by Jan Vesely: 9c8b3290bb34da12571fc201db75c0b13b276834


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.