Bug 88034 - Ruler toobar scaling on HIDPI
Summary: Ruler toobar scaling on HIDPI
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: NeedsHIDPI
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-05 01:23 UTC by Darcy
Modified: 2015-01-22 20:25 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Small rectangles with HIDPI display (540.44 KB, application/pdf)
2015-01-05 01:23 UTC, Darcy
Details
Big rectangles with HIDPI (44.50 KB, image/png)
2015-01-09 01:34 UTC, Darcy
Details
rulerHIDPI patch (16.34 KB, patch)
2015-01-09 01:36 UTC, Darcy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Darcy 2015-01-05 01:23:10 UTC
Created attachment 111741 [details]
Small rectangles with HIDPI display

The ruler in Writer does not scale on HIDPI screens along with other UI elements.  See the attached PDF.

I have gone through ruler.cxx & ruler.hxx and made changes to the define macros to make the rectangles larger and the ruler and ticks the appropriate size.  

However when using GetDPIScaleFactor() member function it quickly gets a little messy with modifying functions to take DPIScalingFactor arguments.  I'm happy to do this but there might be a more preferred way?  Should this be handled lower down in VCL?  This would have benefits that lines drawn would output as 2 px wide rather than 1px as they currently do.

I'm not much of a programmer so be gentle :-)
Comment 1 Robinson Tryon (qubit) 2015-01-07 08:31:25 UTC
Hi Darcy,
It's great to hear that you're working on improving our HIDPI support!

I'm cc'ing one of our Design Team devs; hopefully he'll be able to give you some pointers.

You can also try asking questions on the Dev mailing list and on the Dev IRC channel:
https://wiki.documentfoundation.org/Development/Mailing_List
#libreoffice-dev on Freenode.

Best,
--R
Comment 2 Darcy 2015-01-09 01:34:49 UTC
Created attachment 111985 [details]
Big rectangles with HIDPI

With scaling from rulerHIDPI patch
Comment 3 Darcy 2015-01-09 01:36:47 UTC
Created attachment 111986 [details]
rulerHIDPI patch

Needs work but something along these lines produces the ruler above.
Comment 4 Darcy 2015-01-14 03:42:47 UTC
The patches are on gerrit if someone could review them please?  https://gerrit.libreoffice.org/#/c/13867/