Bug 88081 - [BSW Bisected]Display show black screen when starting gnome-session
Summary: [BSW Bisected]Display show black screen when starting gnome-session
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: high critical
Assignee: Sonika
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
: 88039 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-01-06 02:40 UTC by wendy.wang
Modified: 2017-10-06 14:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg-gnome-blank (124.89 KB, text/plain)
2015-01-06 02:40 UTC, wendy.wang
no flags Details
dmesg info with debug (102.90 KB, text/plain)
2015-10-08 07:40 UTC, ye.tian
no flags Details

Description wendy.wang 2015-01-06 02:40:03 UTC
Created attachment 111803 [details]
dmesg-gnome-blank

System Environment:
--------------------------
Platform: BSW
OS Distribution: Ubuntu 14.04
Kernel regression:
 both latest drm-intel-nightly (07d0c831d9207c937595f081c8fddbddbf53756f)
and drm-intel-next-queued branch fail 


Kernel Regression:
--------------------------
Yes, bisected on drm-intel-next-queued branch:

371abae844ede392066bfc21202b2e40f4a654d1 is the first bad commit
commit 371abae844ede392066bfc21202b2e40f4a654d1
Author: Deepak M <m.deepak@intel.com>
Date:   Mon Dec 15 15:58:21 2014 +0530
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Mon Dec 15 11:25:29 2014 +0100

    drm/i915: Parsing LFP brightness control from VBT

    LFP brighness control from the VBT block 43 indicates which
    controller is used for brightness.
    LFP1 brightness control method:
    Bit 7-4 = This field controller number of the brightnes controller.
    0 = Controller 0
    1 = Controller 1
    2 = Controller 2
    3 = Controller 3
    Others = Reserved
    Bits 3-0 = This field specifies the brightness control pin to be used on the
    platform.
    0 = PMIC pin is used for brightness control
    1 = LPSS PWM is used for brightness control
    2 = Display DDI is used for brightness control
    3 = CABC method to control brightness
    Others = Reserved

    Adding the above fields in dev_priv->vbt and corresponding changes in
    parse_backlight()

    v2: Jani's review comments addressed
        - Move PWM definitions to intel_bios.h
        - Moving vbt_version to intel_vbt_data
        - Rename brightness to bl_ctrl_data
        - Logging just control_pin instead of string
        - Avoid adding vbt_version in dev_priv
        - Since only DDI option is available as of now, let control pin DDI
        affect dev_priv->vbt.backlight.present

    v3: Jani's review comments addressed
        - Drop control_pin
        - Use bdb->version
        - set controller to 0 instead of using control pin define
        - check controller bounds
        - remove superfluous changes in intel_parse_bios

    Signed-off-by: Deepak M <m.deepak@intel.com>
    Signed-off-by: Vandana Kannan <vandana.kannan@intel.com>
    Reviewed-by: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

:040000 040000 1a70f7733307b3dc8545fae58760d314f59f1087 75ec00642c7ee92fda81d0a2f0d74971f8a90164 M      drivers



Reproduce steps:
1. boot into system
2. xinit &
3. screen
4. gnome-session &
will observe display show black screen when starting gnome-session.
Comment 1 wendy.wang 2015-01-06 02:51:13 UTC
gnome-session version: 3.9.90
Other SW stack used 2015-01-04 drivers:
 Libdrm:		(master)libdrm-2.4.58-19-gf99522e678dbbaffeca9462a8edcbe900574dc12
 Mesa:		(master)48094d0e6554a9df36bf00fc2793ade46cf92406
 Xserver:		(master)xorg-server-1.16.99.901-118-gdc777c346d5d452a53b13b917c45f6a1bad2f20b
 Xf86_video_intel:		(master)2.99.917-2-g19a95be5e94841d908633425582e09c7718e3805
 Cairo:		(master)02e4efc961be40d266d4df0acaf3271219529017
 Libva:		(master)e97ac9e78cd475a13e722c455e34d5d39d0f059d
 Libva_intel_driver:		(master)43bd81abdde40b50ac71f6f44eb04e4eaf5af5f6
Comment 2 Rodrigo Vivi 2015-01-06 21:04:03 UTC
*** Bug 88039 has been marked as a duplicate of this bug. ***
Comment 3 Rodrigo Vivi 2015-01-06 21:06:20 UTC
Just for the record it isn't only with gnome-session but a more generic way as pointed out at #88039. I just decided to let this one open because it has the propper bisect and importance.

I also sent out the revert: http://lists.freedesktop.org/archives/intel-gfx/2015-January/058103.html
Comment 4 Chris Wilson 2015-01-06 21:16:31 UTC
In which case the bug here is that gnome-session causes full modeset... :-p
Comment 5 Gordon Jin 2015-01-07 04:42:03 UTC
and bug#87671 got the same bisect.
Comment 6 Jani Nikula 2015-01-07 11:25:16 UTC
commit 9025452366e9a86f2e11292865d98430341005d1
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date:   Tue Jan 6 14:48:15 2015 -0500

    Revert "drm/i915: Parsing LFP brightness control from VBT"
Comment 7 wendy.wang 2015-01-08 08:20:21 UTC
Verified latest drm-intel-nightly branch kernel on BSW, 
We can start gnome-session normally now, so close this bug.

commit 2c812ea86a6644847c1f7a7ca39a2fd0f55eba7a
Author:     Jani Nikula <jani.nikula@intel.com>
AuthorDate: Wed Jan 7 14:12:15 2015 +0200
Commit:     Jani Nikula <jani.nikula@intel.com>
CommitDate: Wed Jan 7 14:12:15 2015 +0200

    drm-intel-nightly: 2015y-01m-07d-12h-11m-48s UTC integration manifest
Comment 8 ye.tian 2015-10-08 07:39:58 UTC
Display show black screen when starting gnome-session on the latest drm-intel-nightly kernel.


Bisected on drm-intel-next-queued branch:

0b5e88dc25ee6c9040c0355e6e025dcbc9c8de92 is the first bad commit

commit 0b5e88dc25ee6c9040c0355e6e025dcbc9c8de92
Author:     Sonika Jindal <sonika.jindal@intel.com>
AuthorDate: Mon Oct 5 16:43:15 2015 +0530
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Tue Oct 6 10:52:22 2015 +0200

    drm/i915: Add hot_plug hook for hdmi encoder

    This patch adds a separate probe function for HDMI
    EDID read over DDC channel. This function has been
    registered as a .hot_plug handler for HDMI encoder.
Comment 9 ye.tian 2015-10-08 07:40:54 UTC
Created attachment 118752 [details]
dmesg info with debug
Comment 10 ye.tian 2015-10-12 02:58:00 UTC
Test it on the latest drm-intel-nightly kernel, this bug does not exists.

commit c38f2c24fb6484fc6900efa6f8d968e8ee964e9c
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Oct 9 14:50:43 2015 +0200

    drm-intel-nightly: 2015y-10m-09d-12h-49m-56s UTC integration manifest
Comment 11 Elizabeth 2017-10-06 14:32:38 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.