Bug 88128 - Unevaluated variable ("Undo: Delete $1") appears in UNDO list after cutting text
Summary: Unevaluated variable ("Undo: Delete $1") appears in UNDO list after cutting text
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.7.2 release
Hardware: Other All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:5.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-06 22:42 UTC by Robinson Tryon (qubit)
Modified: 2017-05-19 09:41 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robinson Tryon (qubit) 2015-01-06 22:42:48 UTC
TESTING on OS X 10.9.5 with LO Version: 4.5.0.0.alpha0+
Build ID: 4d3b725000e537ce6199f0abd1c80580c9bf95c8
TinderBox: MacOSX-x86_64@49-TDF,
Branch:master,
Time: 2015-01-02_10:08:47
Locale: en_

REPRO:
- Open Writer
- Type "turtle", select and cut it (Ctrl-X or any other method)
- View the Edit menu to see unevaluated variable ("Undo: Delete $1")

EXPECTED: Actual cut text to be present

This only appears to work with text that is cut. Deleting text with Backspace or Delete keys works as expected.
Comment 1 Yousuf Philips (jay) (retired) 2015-01-06 22:50:32 UTC
Reported on twitter for 4.2.5 - https://twitter.com/_beechnut/status/552564385181630464
Comment 2 Robinson Tryon (qubit) 2015-01-06 23:04:09 UTC
TESTING with OS X 10.9.5
- 4.4.0.1 - CONFIRMED
- 4.2.8.2 - CONFIRMED
- 3.5.7.2 - CONFIRMED

TESTING with Ubuntu 14.04
- 4.4.0.1 - NOREPRO


Interesting notes: 
Both Firefox (FF) and TextEdit (TE) on the Mac don't mention the text on which I operated:

App Cut Text         Backspace over Text  Delete (Del key) text
--- ---------------  -------------------  ---------------------
LO  Undo: Delete $1  Undo: Delete 'cow'   Undo: Delete 'turtle'
FF  Undo             Undo                 Undo
TE  Undo Cut         Undo Typing          Undo
Comment 3 Yousuf Philips (jay) (retired) 2015-01-07 09:31:58 UTC
@Rob: It would be good to also check the undo/redo drop down menus in the toolbar to check if the problem is in there as well.
Comment 4 retired 2015-01-09 23:26:41 UTC
OSX 10.10.1 LO nightly 2015-01-09
CONFIRMED
Comment 5 Justin L 2015-08-11 11:02:28 UTC
Something similar is also true for replacing a selection with a "space".  type abc.  select abc.  Press space (replacing abc with a space).  Undo reports "Insert $1".  Bibisected: occurs in oldest version 3.5.
Comment 6 Justin L 2015-09-28 05:46:25 UTC
changed OS to all.  I am reproducing this on Linux Mint/Maya (precise) and Mint/Rebecca (Trusty) using 5.1 dev.  Reproduced on Windows 2003 Server with 4.3.7. (I'm typing 'turtle' in a new document, selecting it, and pressing Ctrl-X)

(However, the abc replaced with space in Windows/4.3.7 says "replace 'abc' ->  and not insert $1)

Robinson: not sure how you got delete 'turtle' to work in 14.04.  Bibisect-43all on Mint/Rebecca shows the problem as far back as "oldest" LO 3.5.
Comment 7 Commit Notification 2015-10-01 08:06:32 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=52ea9712c424e3647fb67631806b8661baeaa150

tdf#88128 fix unevaluated undo variable: cut

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2015-10-02 10:47:59 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=329e6f1a033dc45e9d9f7a50e3237bb65618ed3f

tdf#88128 fix unevaluated undo variable: autocorrect

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.