Bug 88280 - Actions are not defined for some detected DE's (Enlightenment, Mate) in xdg-su xdg-terminal and others (partial patch)
Summary: Actions are not defined for some detected DE's (Enlightenment, Mate) in xdg-s...
Status: NEW
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: All All
: medium minor
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-10 21:01 UTC by simon
Modified: 2015-09-23 01:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fix enlightenment patch (2.32 KB, patch)
2015-01-12 07:59 UTC, simon
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description simon 2015-01-10 21:01:38 UTC
It seems like in several cases detection is added for a desktop environment then a action is added to say xdg-open but not xdg-su or xdg-terminal, this causes them to fail rather then using the generic option as they would have in the past.

xdg-su and xdg-terminal are both broken in this way on enlightenment as the support is detected for xdg-open but nothing is specified for the other cases. 

The following patch https://build.opensuse.org/package/view_file/X11:common:Factory/xdg-utils/fix-enlightenment-support.patch?expand=1 fixes and enhances enlightenment support by using enlightenments terminal emulator (terminology) rather then xterm.

When i was looking at this issue in more detail it seemed like mate suffered from a similar issue in atleast 1 tool but all should probably be checked to see they have a action for each tool, if not they need to run the generic tool.
Comment 1 Rex Dieter 2015-01-11 03:39:48 UTC
thanks.

(Yes, these could probably use a lot more love, there's a reason they're not enabled by default).
Comment 2 Rex Dieter 2015-01-11 13:59:56 UTC
Can you attach the bug please?

It's not clear to me how to extract the raw patch from the link you provided.
Comment 3 simon 2015-01-12 07:59:38 UTC
Created attachment 112114 [details] [review]
fix enlightenment patch
Comment 4 simon 2015-01-12 08:00:07 UTC
Sorry the link is on the previous page, attached now
Comment 5 Per Olofsson 2015-09-23 01:49:42 UTC
I'm lowering the importance to minor because these tools aren't really part of xdg-utils since they are not installed by the build system.

Regarding xdg-su, shouldn't it be deprecated in favour of PolicyKit?

xdg-terminal could be useful though.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.