Bug 8892 (dmx-input-port) - dmx needs porting to the new input api
Summary: dmx needs porting to the new input api
Status: RESOLVED FIXED
Alias: dmx-input-port
Product: xorg
Classification: Unclassified
Component: Server/DDX/dmx (show other bugs)
Version: git
Hardware: Other other
: high major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 9617 9915 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-11-05 04:17 UTC by Bernhard Rosenkraenzer
Modified: 2010-05-06 14:00 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (742 bytes, patch)
2006-11-05 04:18 UTC, Bernhard Rosenkraenzer
no flags Details | Splinter Review

Description Bernhard Rosenkraenzer 2006-11-05 04:17:26 UTC
SSIA - current git xf86-input-keyboard tries to #include xf86Keymap.h, which 
doesn't get installed. Older xf86-input-keyboard versions don't work because 
of the xf86OSKbd.h removal.
Comment 1 Bernhard Rosenkraenzer 2006-11-05 04:18:28 UTC
Created attachment 7655 [details] [review]
Patch

Attaching patch to xorg-server Makefile.am to make sure xf86Keymap.h gets
installed along with the other SDK headers
Comment 2 numenyaron 2007-01-01 04:14:00 UTC
(In reply to comment #1)
> Created an attachment (id=7655) [edit]
> Patch
> 
> Attaching patch to xorg-server Makefile.am to make sure xf86Keymap.h gets
> installed along with the other SDK headers

I just downloaded all the sources from anongit.freedesktop.org yesterday to
build  X from scratch and I am also getting an error about a missing
xf86Keymap.h; the including file is xserver/hw/dmx/input/lnx-keyboard.c, line 167.
Comment 3 David Ronis 2007-01-08 19:34:15 UTC
I think I'm hit by this bug as well.  I'm using today's git sources:  I get,
in xserver/hw/dmx/input/lnx-keyboard.c
        
        if /usr/bin/gcc -DHAVE_CONFIG_H -I. -I. -I../../../include
        -I../../../include -I../../..
        /include -I../../../include -I../../../include -I../../../include
        -I../../../include -I.
        ./../../include    -DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith
        -Wstrict-prototypes -Wmissi
        ng-prototypes -Wmissing-declarations -Wnested-externs
        -fno-strict-aliasing -D_BSD_SOURCE
         -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R7.1/include
        -I/usr/include/dbus-1.0 -I/usr
        /lib/dbus-1.0/include   -I../../../include -I../../../include
        -I../../../Xext -I../../..
        /composite -I../../../damageext -I../../../xfixes -I../../../Xi
        -I../../../mi -I../../..
        /miext/shadow  -I../../../miext/damage -I../../../render
        -I../../../randr -I../../../fb 
        -I../../../hw/dmx -I../../../hw/xfree86/common
        -I/home/ronis/xc/mesa//include -DHAVE_DMX
        _CONFIG_H -I/usr/X11R7.1/include   -I/usr/X11R7.1/include   -O3
        -march=pentium4 -ffast-m
        ath -funroll-loops -fomit-frame-pointer -MT lnx-keyboard.o -MD -MP -MF
        ".deps/lnx-keyboa
        rd.Tpo" -c -o lnx-keyboard.o lnx-keyboard.c; \
                then mv -f ".deps/lnx-keyboard.Tpo" ".deps/lnx-keyboard.Po";
        else rm -f ".deps/l
        nx-keyboard.Tpo"; exit 1; fi
        lnx-keyboard.c:167:24: error: xf86Keymap.h: No such file or directory
        lnx-keyboard.c: In function 'kbdLinuxReadKernelMapping':
        lnx-keyboard.c:803: error: 'map' undeclared (first use in this function)
        lnx-keyboard.c:803: error: (Each undeclared identifier is reported only
        once
        lnx-keyboard.c:803: error: for each function it appears in.)
        lnx-keyboard.c: In function 'kbdLinuxGetMap':
        lnx-keyboard.c:930: error: 'map' undeclared (first use in this function)
        
        
        There is a file by that name
        in ./driver/xf86-input-keyboard/src/xf86Keymap.h
        but this doesn't seem to have made my prefix:  /usr/X11R7.1/include by
        the time it's needed (assuming it's the correct file).  I'm going to try
        and fix this by adding it manually to /usr/X11R7.1/include.
        
Comment 4 Daniel Stone 2007-01-11 13:35:31 UTC
*** Bug 9617 has been marked as a duplicate of this bug. ***
Comment 5 David Ronis 2007-01-11 13:45:50 UTC
(In reply to comment #4)
> *** Bug 9617 has been marked as a duplicate of this bug. ***

As I suspected; however the patch was created on Nov 5--2 months ago, and
doesn't seem to have been merged into the source tree, or my git didn't pick it
up (unlikely).



Comment 6 Daniel Stone 2007-01-11 13:56:02 UTC
the patch doesn't solve the problem.  the problem is that dmx has not been
ported to the new input api, and that's a pretty involved task.
Comment 7 George - 2007-02-08 09:22:52 UTC
*** Bug 9915 has been marked as a duplicate of this bug. ***
Comment 8 Daniel Stone 2007-02-27 01:34:23 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 9 Adam Jackson 2010-05-06 14:00:42 UTC
This is basically sorted now, thanks Peter.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.