Created attachment 113140 [details] [review]
Use static inline instead of just inline.
Beignet uses the inline keyword. When building on FreeBSD 10.0-R or newer it will be compiled with the clang compiler. When building with clang the build fails unresolved symbols.
../src/libcl.so: undefined reference to `handle_events'
../src/libcl.so: undefined reference to `isBitcodeWrapper'
../src/libcl.so: undefined reference to `isRawBitcode'
../src/libcl.so: undefined reference to `cl_event_is_gpu_command_type'
Switch to static inline instead of inline fixes the build. If I remember the facts correctly, clang defaults to gnu99 standard instead of gcc which default to gnu89 standard. And the inline keywords means something different in gnu89 vs gnu99 standard.
The patch LGTM, could you send it to the mail list with your signed-off-by
ping for response, thanks.
This now appears to be fixed: 1.2.0 builds with clang 3.8 and works. (I tested with GNU libstdc++, but comments in bug 94636 suggest LLVM libc++ now also works.)
(It's also gained another Linux-only system call, but an easy one to avoid: https://anonscm.debian.org/cgit/pkg-opencl/beignet.git/tree/debian/patches/support-kfreebsd.patch )