Bug 88980 - MinGW compile of autotools build system broken
Summary: MinGW compile of autotools build system broken
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: git master
Hardware: Other Windows (All)
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-05 04:41 UTC by Ralf Habacker
Modified: 2015-02-05 14:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
MinGW build log (120.14 KB, text/plain)
2015-02-05 04:41 UTC, Ralf Habacker
Details
[1/2] tests: make sure to specify CPPFLAGS where needed (1.06 KB, patch)
2015-02-05 12:49 UTC, Simon McVittie
Details | Splinter Review
[2/2] tests: make installable metadata Windows-friendly by using EXEEXT (1.09 KB, patch)
2015-02-05 12:50 UTC, Simon McVittie
Details | Splinter Review

Description Ralf Habacker 2015-02-05 04:41:38 UTC
Created attachment 113171 [details]
MinGW build log

Cross compiling dbus git master with autotools is currently broken. For details see appended build log.
Comment 1 Simon McVittie 2015-02-05 11:49:19 UTC
I'll look into this when I get my mingw build environment back up.
Comment 2 Simon McVittie 2015-02-05 12:49:41 UTC
Created attachment 113194 [details] [review]
[1/2] tests: make sure to specify CPPFLAGS where needed

test-marshal and test-syntax need the
$(testutils_shared_if_possible_cppflags), so that they will get the
$(static_cflags) when we are not linking to dbus-glib.
Comment 3 Simon McVittie 2015-02-05 12:50:08 UTC
Created attachment 113195 [details] [review]
[2/2] tests: make installable metadata Windows-friendly by  using EXEEXT

---

With those two patches, my local mingw build works.
Comment 4 Ralf Habacker 2015-02-05 14:11:58 UTC
Comment on attachment 113194 [details] [review]
[1/2] tests: make sure to specify CPPFLAGS where needed

Review of attachment 113194 [details] [review]:
-----------------------------------------------------------------

looks good
Comment 5 Ralf Habacker 2015-02-05 14:12:12 UTC
Comment on attachment 113195 [details] [review]
[2/2] tests: make installable metadata Windows-friendly by  using EXEEXT

Review of attachment 113195 [details] [review]:
-----------------------------------------------------------------

looks good
Comment 6 Ralf Habacker 2015-02-05 14:12:42 UTC
(In reply to Simon McVittie from comment #3)
> Created attachment 113195 [details] [review] [review]
> [2/2] tests: make installable metadata Windows-friendly by  using EXEEXT
> 
> ---
> 
> With those two patches, my local mingw build works.
I can confirm this for cross compiled mingw32 builds.
Comment 7 Simon McVittie 2015-02-05 14:15:03 UTC
Fixed in git for 1.9.10, thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.