Bug 89057 - [IVB 10.4]Piglit spec_ARB_gpu_shader5_arb_gpu_shader5-interpolateAtOffset-nonconst fails
Summary: [IVB 10.4]Piglit spec_ARB_gpu_shader5_arb_gpu_shader5-interpolateAtOffset-non...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: 10.4
Hardware: All Linux (All)
: medium normal
Assignee: Ian Romanick
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-10 07:28 UTC by lu hua
Modified: 2016-11-02 01:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2015-02-10 07:28:27 UTC
System Environment:
--------------------------
Platform: IVB
Libdrm:         (master)libdrm-2.4.59-8-gccbb9aa887f992359335ecf2d26919b04e14e63f
Mesa:           (10.4)54da987baec25fbaf6975c93f197ddbfe65a303c
Xserver:     (server-1.16-branch)xorg-server-1.16.3-6-g0722a8043c89e7224c398eef270611cc65c1e219
Xf86_video_intel:   (master)2.99.917-100-g5b033d638bbf2c0b841088ca75f9eb8de5852cb5
Libva:          (master)f9741725839ea144e9a6a1827f74503ee39946c3
Libva_intel_driver:     (master)9a20d6c34cb65e5b85dd16d6c8b3a215c5972b18

Bug detailed description:
---------------------------
It fails on mesa 10.4 branch, works well on master branch. In earlier automation testing, it pass, but I am unable to reproduce the pass.

output:
libGL: screen 0 does not appear to be DRI3 capable
libGL: pci id for fd 4: 8086:0152, driver i965
libGL: OpenDriver: trying /opt/X11R7/lib/dri/tls/i965_dri.so
libGL: OpenDriver: trying /opt/X11R7/lib/dri/i965_dri.so
Probe color at (3,0)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.764706 0.000000
PIGLIT: {"result": "fail" }


output on master:
libGL: OpenDriver: trying /opt/X11R7/lib/dri/tls/i965_dri.so
libGL: OpenDriver: trying /opt/X11R7/lib/dri/i965_dri.so
PIGLIT: {"result": "pass" }

==Reproduce steps==
---------------------------- 
1. xinit
2. bin/arb_gpu_shader5-interpolateAtOffset-nonconst -auto -fbo
Comment 1 Ian Romanick 2015-02-11 22:11:02 UTC
Did the test change?  Are you able to bisect from 10.4 to master to see where it was "fixed"?
Comment 2 lu hua 2015-02-12 05:50:48 UTC
(In reply to Ian Romanick from comment #1)
> Did the test change?  Are you able to bisect from 10.4 to master to see
> where it was "fixed"?

I reset the same test environment, I am unable to reproduce the pass.
test log(pass):
@test: Piglit/spec_ARB_gpu_shader5_arb_gpu_shader5-interpolateAtOffset-nonconst
info: @@@Returncode: 0


test case start at: Sat Feb  7 18:50:09 2015
test case end at:   Sat Feb  7 18:50:09 2015

Errors:
libGL: screen 0 does not appear to be DRI3 capable
libGL: pci id for fd 7: 8086:0152, driver i965
libGL: OpenDriver: trying /opt/X11R7/lib/dri/tls/i965_dri.so
libGL: OpenDriver: trying /opt/X11R7/lib/dri/i965_dri.so


Dmesg:

Output:
 bin/arb_gpu_shader5-interpolateAtOffset-nonconst -auto -fbo
PIGLIT: {"result": "pass" }


Bisect on master branch, 092c73a7c32b240a26ffeab2ee475f6d590540b2 fixed it.
commit 092c73a7c32b240a26ffeab2ee475f6d590540b2
Author: Chris Forbes <chrisf@ijw.co.nz>
Date:   Sun Dec 7 10:12:36 2014 +1300

    i965: Fix regs read for FS_OPCODE_INTERP_PER_SLOT_OFFSET

    Dead code elimination was eating the Y offset.

    Fixes the piglit test:
    spec/ARB_gpu_shader5/arb_gpu_shader5-interpolateAtOffset-nonconst

    Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
    Reviewed-by: Jason Ekstrand <jason.ekstrand@intel.com>
Comment 3 Matt Turner 2016-11-02 01:22:22 UTC
Test now passes.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.