Hello I found gstreamer-plugins-good failing to build due to this: pulseutil.c: In function 'gst_pulse_fill_format_info': pulseutil.c:167:5: error: missing binary operator before token "~" #if PA_CHECK_VERSION(3,99,0) ^ Looking at /usr/include/pulse/version.h, I saw this: /** The major version of PA. \since 0.9.15 */ #define PA_MAJOR 6 /** The minor version of PA. \since 0.9.15 */ #define PA_MINOR 0~8 /** The micro version of PA (will always be 0 from v1.0 onwards). \since 0.9.15 */ #define PA_MICRO 0 The reason seems to be that the `git-version-gen` script is returning this when tag v5.99.3 is checked out: ./git-version-gen . 6.0~8 Seems like this is a bug in the git-version-gen script (or at least, unexpected behaviour that causes 'configure' to come up with an invalid version number). I'm afraid I don't have time to look at this now and have just upgraded to 6.0 instead, which currently doesn't suffer this issue.
Did you hand-roll your 5.99.3 tarball, or is your distro doing something wrong? I see this in our released version: /** The major version of PA. \since 0.9.15 */ #define PA_MAJOR 5 /** The minor version of PA. \since 0.9.15 */ #define PA_MINOR 99 /** The micro version of PA (will always be 0 from v1.0 onwards). \since 0.9.15 */ #define PA_MICRO 0
This is building directly from the Git repo. No tarball. Sorry, I should have been clear about that.
Are there any other tags being added to your git tree, or is this a pristine checkout from our fdo repo?
It's a pristine checkout of a mirror of the fdo repo. The mirror is at http://git.baserock.org/cgi-bin/cgit.cgi/delta/pulseaudio.git I've tested if the problem occurs with git://anongit.freedesktop.org/pulseaudio/pulseaudio and I get the same result. The build used to be good, I think it's the appearance of the v6.0 tag that has triggered this bug.
One data point: in my checkout (I don't think it counts as "pristine") I quickly tried this: git checkout v5.99.3 make make install /usr/local/include/pulse/version.h now has this: /** The major version of PA. \since 0.9.15 */ #define PA_MAJOR 5 /** The minor version of PA. \since 0.9.15 */ #define PA_MINOR 99 /** The micro version of PA (will always be 0 from v1.0 onwards). \since 0.9.15 */ #define PA_MICRO 0 That is, I couldn't reproduce the bug with these steps.
Thanks for testing it out! The git-version-gen script is called by configure, so you will need to rerun configure to trigger the bug.
Indeed, I now reproduced the bug.
I should mention that my activity in this bug doesn't mean that I'll fix this. If this bug is made a release blocker, I will work on this, otherwise I probably won't. I suppose a good starting point would be to check if the git-version-gen script has been already fixed where it originated from. Quoting a comment in the script: # This script is derived from GIT-VERSION-GEN from GIT: http://git.or.cz/.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/148.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.