Bug 8916 - error: #error
Summary: error: #error
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.1 (2006.05)
Hardware: PowerPC Mac OS X (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-06 02:47 UTC by Peter Dyballa
Modified: 2007-03-11 14:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Proposed patch to make xserver/hw/darwin/darwin.c (767 bytes, patch)
2006-11-06 09:35 UTC, Peter Dyballa
no flags Details | Splinter Review

Description Peter Dyballa 2006-11-06 02:47:47 UTC
hile making the X server in xserver/hw/darwin/darwin.c these errors are reported:

In file included from darwin.c:45:
../../hw/xfree86/common/xorgVersion.h:33:4: error: #error 
In file included from ../../include/xorg-config.h:13,
                 from ../../hw/xfree86/common/xf86Date.h:29,
                 from darwin.c:46:
../../include/dix-config.h:20:1: warning: "COMPILEDDEFAULTFONTPATH" redefined
In file included from darwin.c:43:
../../include/site.h:76:1: warning: this is the location of the previous definition
In file included from ../../include/xorg-config.h:13,
                 from ../../hw/xfree86/common/xf86Date.h:29,
                 from darwin.c:46:
../../include/dix-config.h:415:1: warning: "X_BYTE_ORDER" redefined
In file included from ../../include/colormapst.h:51,
                 from ../../mi/micmap.h:2,
                 from darwin.c:41:
/usr/X11R7/include/X11/Xarch.h:120:1: warning: this is the location of the previous definition
In file included from ../../include/xorg-config.h:13,
                 from ../../hw/xfree86/common/xf86Date.h:29,
                 from darwin.c:46:
../../include/dix-config.h:441:1: warning: "RGB_DB" redefined
In file included from darwin.c:43:
../../include/site.h:79:1: warning: this is the location of the previous definition
In file included from darwin.c:71:
darwin.h:50: warning: function declaration isn’t a prototype
darwin.c:129: warning: function declaration isn’t a prototype
darwin.c: In function ‘DarwinAddScreen’:
darwin.c:241: warning: target of assignment not really an lvalue; this will be a hard error in the future
darwin.c:316: warning: implicit declaration of function ‘ShmRegisterFbFuncs’
darwin.c:316: warning: nested extern declaration of ‘ShmRegisterFbFuncs’
darwin.c: In function ‘DarwinMouseProc’:
darwin.c:414: warning: pointer targets in passing argument 2 of ‘InitPointerDeviceStruct’ differ in 
signedness
darwin.c:414: error: too few arguments to function ‘InitPointerDeviceStruct’
darwin.c: At top level:
darwin.c:947: warning: no previous prototype for ‘DPMSSupported’
darwin.c:952: warning: no previous prototype for ‘DPMSSet’
darwin.c:956: warning: no previous prototype for ‘DPMSGet’

This patch corrects the error:

33,36d32
< #ifdef HAVE_XORG_CONFIG_H
< #include <xorg-config.h>
< #endif
< 
418,419c414
<                         0,
<                         2 );
---
>                         0 );

This warning, referencing the former error, is still left:

	darwin.c:419: warning: pointer targets in passing argument 2 of ‘InitPointerDeviceStruct’ differ in 
signedness

Mac OS X 10.4.8
GCC 4.0.1
Release 7.1.99.2
Comment 1 Alan Coopersmith 2006-11-06 08:32:12 UTC
Please use "diff -u" when generating patches that you are submitting for
inclusion - diff arrows format breaks far too easily and is much harder
to read.   (Also, patches are preferred in attachments in bugzilla instead 
of the body of comments so that they can be easily saved and applied instead
of having to copy and paste and hope you got the spacing right.)
Comment 2 Peter Dyballa 2006-11-06 09:35:55 UTC
Created attachment 7667 [details] [review]
Proposed patch to make xserver/hw/darwin/darwin.c
Comment 3 Peter Dyballa 2006-11-06 09:54:10 UTC
(In reply to comment #1)
> Please use "diff -u" when generating patches that you are submitting for
> inclusion - diff arrows format breaks far too easily and is much harder
> to read.   (Also, patches are preferred in attachments in bugzilla instead 
> of the body of comments so that they can be easily saved and applied instead
> of having to copy and paste and hope you got the spacing right.)

I correct all my bug reports with "inline" patches!
Comment 4 Peter Dyballa 2006-11-08 13:21:45 UTC
Part of this patch was originally written by Peter O'Gorman.
Comment 5 Daniel Stone 2007-02-27 01:34:29 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 6 Peter Dyballa 2007-03-11 14:11:04 UTC
Some warnings are left.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.