Bug 89253 - telepathy-gabble ignores some messages
Summary: telepathy-gabble ignores some messages
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-02-21 00:18 UTC by Nils Dagsson Moskopp
Modified: 2015-02-21 13:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch to fix bug; deleted code is debugged code (1.04 KB, text/plain)
2015-02-21 00:18 UTC, Nils Dagsson Moskopp
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Dagsson Moskopp 2015-02-21 00:18:53 UTC
Created attachment 113708 [details]
patch to fix bug; deleted code is debugged code

telepathy-gabble deliberately ignores MUC messages coming directly from a room and not from someone in the room. An example for such message is a title change in a room or announcements upon joining that a room is not anonymous (it means everyone can see your JID).

I have a patch, which is already applied in Maemo: <https://gitorious.org/community-ssu/telepathy-gabble/commit/f5d37a5ddf21d0053b369bf59f5edebfe1c91ceb/diffs/08c7a9dae2fb55d67fc01ba90f1f3889393ef400>

The code I removed with the patch was introduced in commit d4d5a2f99eb5e1a2471662c09ff04aee865dde36, made by Will Thompson <will.thompson@collabora.co.uk> on Wed Nov 12 11:31:15 2008 +0000.
Comment 1 Vivek Dasmohapatra 2015-02-21 00:25:00 UTC
Patch looks reasonable to me... I can't think of/don't
know of any reason to ignore these messages.
Comment 2 Vivek Dasmohapatra 2015-02-21 13:35:02 UTC
Will (original committer) says:

I do not remember if it was a “bug” per se. I think either a user or
Empathy was surprised by them? IIRC there's no especially good way to
represent “this is a message from the room itself” so clients got
confused, showed “unknown” or similar?

So probably it was to do with the way things dealt with these messages
at the UI level.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.