PKG_CONFIG_LIBDIR overrides the builtin pkg-config path, but you'd never know it from the name. Not only does it not say it's a path variable, but the standard path has also include a datadir arch-independent directory for years. I propose to change this to PKG_CONFIG_SYSTEM_PATH, silently accepting PKG_CONFIG_LIBDIR for compatibility.
Created attachment 113726 [details] [review] [PATCH] Prefer envvar PKG_CONFIG_SYSTEM_PATH for overriding default path Currently PKG_CONFIG_LIBDIR is used to override the default search path, but this is really a poor name for what it's accomplishing. Accept a new variable, PKG_CONFIG_SYSTEM_PATH, for this purpose but fallback to PKG_CONFIG_LIBDIR to maintain compatibility. https://bugs.freedesktop.org/show_bug.cgi?id=89268 --- README.win32 | 4 ++-- check/check-gtk | 2 +- check/check-path | 2 +- check/check-print-options | 2 +- check/common | 4 ++-- main.c | 9 +++++++-- pkg-config.1 | 5 ++++- pkg.m4 | 4 ++-- 8 files changed, 20 insertions(+), 12 deletions(-)
Created attachment 113727 [details] [review] [PATCH] Prefer envvar PKG_CONFIG_SYSTEM_PATH for overriding default path Currently PKG_CONFIG_LIBDIR is used to override the default search path, but this is really a poor name for what it's accomplishing. Accept a new variable, PKG_CONFIG_SYSTEM_PATH, for this purpose but fallback to PKG_CONFIG_LIBDIR to maintain compatibility. https://bugs.freedesktop.org/show_bug.cgi?id=89268 --- README.win32 | 4 ++-- check/check-gtk | 2 +- check/check-path | 2 +- check/check-print-options | 2 +- check/check-relocatable | 8 ++++---- check/common | 4 ++-- main.c | 9 +++++++-- pkg-config.1 | 5 ++++- pkg.m4 | 4 ++-- 9 files changed, 24 insertions(+), 16 deletions(-)
Comment on attachment 113726 [details] [review] [PATCH] Prefer envvar PKG_CONFIG_SYSTEM_PATH for overriding default path Updated to include a couple spots PKG_CONFIG_LIBDIR was hanging around in.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pkg-config/pkg-config/issues/40.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.