Bug 89361 - Dual Monitors Issue. Weston gives both the same name.
Summary: Dual Monitors Issue. Weston gives both the same name.
Status: RESOLVED FIXED
Alias: None
Product: Wayland
Classification: Unclassified
Component: weston (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-27 14:51 UTC by i
Modified: 2016-03-18 02:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fixes bug by giving each monitor a different name. (389 bytes, text/plain)
2015-02-27 14:51 UTC, i
Details
Log from unpatched weston (Both monitors have same name: DVI1) (5.48 KB, text/plain)
2015-02-27 14:52 UTC, i
Details
Log from weston patched with the above patch. (6.66 KB, text/plain)
2015-02-27 14:53 UTC, i
Details

Description i 2015-02-27 14:51:20 UTC
Created attachment 113868 [details]
Fixes bug by giving each monitor a different name.

This makes configuring them separately impossible.

One of the monitors is dual link DVI and the other one is single link DVI which pmost likely causes the issue.

Fixed with attached patch.
Comment 1 i 2015-02-27 14:52:48 UTC
Created attachment 113869 [details]
Log from unpatched weston (Both monitors have same name: DVI1)
Comment 2 i 2015-02-27 14:53:46 UTC
Created attachment 113870 [details]
Log from weston patched with the above patch.
Comment 3 Pekka Paalanen 2015-08-19 07:48:12 UTC
Patches should be sent to mailing list with 'git send-email'. However, the proposed patch does not use any familiar names.

It seems compositor-drm.c's output naming could probably use even more fixing, looking at drmmode_create_name() in http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/drivers/modesetting/drmmode_display.c#n1358 .

OTOH, I suppose we should leave MST support for another time, and just fix the current stuff.

Comparing our name table in compositor-drm.c to that of -modesetting's, it seems it should have the same issue, Weston is missing a couple of entries, and not just DVI but also TV and HDMI entries might theoretically produce duplicates.

Weston is also using slightly different names on some. Makes me wonder what convention we should follow.

The actual meanings I think are authoritatively defined here with the DRM_MODE_CONNECTOR_*:
http://cgit.freedesktop.org/mesa/drm/tree/include/drm/drm_mode.h#n201
The name tables just follow that exact ordering.

Have you tried if Xorg with -modesetting driver has the same identical name issue? If they have, you might want to file a bug for that too.
Comment 4 Pekka Paalanen 2015-08-19 12:55:33 UTC
Patch sent to the list:
http://lists.freedesktop.org/archives/wayland-devel/2015-August/023971.html
Comment 5 Bryce Harrington 2016-03-18 02:53:04 UTC
The aforementioned patch has landed in trunk.

https://lists.freedesktop.org/archives/wayland-devel/2015-August/024017.html


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.