mesa: b5eb6f769db71557c86c72c3352db149379fdade (master 10.6.0-devel) -Wvla is available with gcc >= 4.3. Build fails with this error. cc1: error: -Werror=vla: No option -Wvla
Created attachment 114016 [details] [review] make -Wvla conditional How about the attached patch to make it conditional on the GCC version?
(In reply to Jonathan Gray from comment #1) > Created attachment 114016 [details] [review] [review] > make -Wvla conditional > > How about the attached patch to make it conditional on the GCC version? Thanks for looking into this. I worry that checking the compiler version might not work for clang. It might be better to mimic the logic we use above for -Werror=implicit-function-declaration and -Werror=missing-prototypes.
Created attachment 114359 [details] [review] check if compiler supports -Werror=vla new patch that does a compile check for the flag
(In reply to Jonathan Gray from comment #3) > Created attachment 114359 [details] [review] [review] > check if compiler supports -Werror=vla > > new patch that does a compile check for the flag configure.ac is basically m4 on top of shell/bash, right? If so the check must be done MSVC2013_COMPAT_* vars are referred in the MSVC2008_COMPAT_* assignment. Otherwise looks good.
"... check must be done _before_ MSVC2013_COMPAT_* ..."
I've updated and pushed your fix (8475526a3842580f00a043bca8f821e14e9f5eb7) Thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.