Bug 89546 - [SKL] S3 times out waiting for flip when disabling the pipe
Summary: [SKL] S3 times out waiting for flip when disabling the pipe
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-11 17:44 UTC by Timo Aaltonen
Modified: 2017-07-24 22:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Timo Aaltonen 2015-03-11 17:44:39 UTC 
Trying drm-next from today (included drm-intel-next -02-27) fails to suspend/resume properly on Skylake:

<--
[   28.887720] sd 0:0:0:0: [sda] Stopping disk
[   88.897339] ------------[ cut here ]------------
[   88.897441] WARNING: CPU: 1 PID: 2080 at /home/kernel/COD/linux/drivers/gpu/drm/i915/intel_display.c:3707 intel_crtc_wait_for_pending_flips+0x172/0x200 [i915]()
[   88.897444] WARN_ON(wait_event_timeout(dev_priv->pending_flip_queue, !intel_crtc_has_pending_flip(crtc), 60*HZ) == 0)
[   88.897501] Modules linked in: ctr ccm nls_iso8859_1 arc4 rt2800usb rt2x00usb rt2800lib rt2x00lib mac80211 crc_ccitt snd_hda_codec_realtek snd_hda_codec_generic xhci_plat_hcd x86_pkg_temp_thermal coretemp joydev kvm_intel snd_hda_intel snd_hda_controller dwc3 kvm udc_core snd_hda_codec snd_hwdep snd_pcm crct10dif_pclmul snd_seq_midi i915 snd_seq_midi_event crc32_pclmul snd_rawmidi ghash_clmulni_intel snd_seq aesni_intel snd_seq_device aes_x86_64 snd_timer lrw drm_kms_helper gf128mul hid_lenovo glue_helper ablk_helper drm snd iwlwifi cryptd soundcore serio_raw cfg80211 i2c_algo_bit wmi shpchp i2c_hid dwc3_pci soc_button_array winbond_cir rc_core 8250_fintek int3403_thermal video int3402_thermal int3400_thermal acpi_thermal_rel int340x_thermal_zone acpi_pad mac_hid sunrpc parport_pc ppdev lp parport
[   88.897510]  autofs4 usbhid hid psmouse ahci sdhci_pci libahci sdhci_acpi sdhci
[   88.897516] CPU: 1 PID: 2080 Comm: kworker/u16:8 Tainted: G        W       4.0.0-996-generic #201503111121
[   88.897518] Hardware name: Intel Corporation Skylake Client platform/Skylake Y LPDDR3 RVP3, BIOS SKLSE2R1.86C.B066.R01.1501080220 01/08/2015
[   88.897529] Workqueue: events_unbound async_run_entry_fn
[   88.897535]  0000000000000e7b ffff88008a4afa68 ffffffff817df8df ffffffff81c4d508
[   88.897538]  ffff88008a4afab8 ffff88008a4afaa8 ffffffff810791a7 0000000000000286
[   88.897542]  ffff880148b1e000 ffff8800366f9000 ffff8800366f91a8 ffff8800893b86d0
[   88.897543] Call Trace:
[   88.897552]  [<ffffffff817df8df>] dump_stack+0x45/0x57
[   88.897559]  [<ffffffff810791a7>] warn_slowpath_common+0x97/0xe0
[   88.897565]  [<ffffffff810792a6>] warn_slowpath_fmt+0x46/0x50
[   88.897573]  [<ffffffff810bafd7>] ? finish_wait+0x67/0x80
[   88.897620]  [<ffffffffc0872e22>] intel_crtc_wait_for_pending_flips+0x172/0x200 [i915]
[   88.897625]  [<ffffffff810baea0>] ? prepare_to_wait_event+0x100/0x100
[   88.897668]  [<ffffffffc0873cdc>] intel_crtc_disable_planes+0x2c/0x140 [i915]
[   88.897708]  [<ffffffffc0874325>] haswell_crtc_disable+0x55/0x2d0 [i915]
[   88.897748]  [<ffffffffc0874d37>] intel_crtc_control+0x57/0x130 [i915]
[   88.897768]  [<ffffffffc080158a>] i915_drm_suspend+0xaa/0x1d0 [i915]
[   88.897788]  [<ffffffffc08016df>] i915_pm_suspend+0x2f/0x50 [i915]
[   88.897796]  [<ffffffff81402578>] pci_pm_suspend+0x88/0x140
[   88.897801]  [<ffffffff817c847a>] ? klist_next+0x8a/0x100
[   88.897806]  [<ffffffff814024f0>] ? pci_pm_freeze+0xe0/0xe0
[   88.897811]  [<ffffffff8151a5b8>] dpm_run_callback+0x58/0xd0
[   88.897816]  [<ffffffff8151a742>] __device_suspend+0x112/0x370
[   88.897820]  [<ffffffff8151b53f>] async_suspend+0x1f/0xa0
[   88.897826]  [<ffffffff8109b0ac>] async_run_entry_fn+0x4c/0x160
[   88.897834]  [<ffffffff81092094>] process_one_work+0x144/0x490
[   88.897837]  [<ffffffff81092afe>] worker_thread+0x11e/0x450
[   88.897841]  [<ffffffff810929e0>] ? create_worker+0x1f0/0x1f0
[   88.897845]  [<ffffffff81098769>] kthread+0xc9/0xe0
[   88.897851]  [<ffffffff810986a0>] ? flush_kthread_worker+0x90/0x90
[   88.897856]  [<ffffffff817ebf98>] ret_from_fork+0x58/0x90
[   88.897860]  [<ffffffff810986a0>] ? flush_kthread_worker+0x90/0x90
[   88.897864] ---[ end trace e37c0e2ec2c7edb4 ]---
[   88.897865] ------------[ cut here ]------------
[   88.897905] WARNING: CPU: 1 PID: 2080 at /home/kernel/COD/linux/drivers/gpu/drm/i915/intel_display.c:3712 intel_crtc_wait_for_pending_flips+0x1f3/0x200 [i915]()
[   88.897907] Removing stuck page flip
[   88.897956] Modules linked in: ctr ccm nls_iso8859_1 arc4 rt2800usb rt2x00usb rt2800lib rt2x00lib mac80211 crc_ccitt snd_hda_codec_realtek snd_hda_codec_generic xhci_plat_hcd x86_pkg_temp_thermal coretemp joydev kvm_intel snd_hda_intel snd_hda_controller dwc3 kvm udc_core snd_hda_codec snd_hwdep snd_pcm crct10dif_pclmul snd_seq_midi i915 snd_seq_midi_event crc32_pclmul snd_rawmidi ghash_clmulni_intel snd_seq aesni_intel snd_seq_device aes_x86_64 snd_timer lrw drm_kms_helper gf128mul hid_lenovo glue_helper ablk_helper drm snd iwlwifi cryptd soundcore serio_raw cfg80211 i2c_algo_bit wmi shpchp i2c_hid dwc3_pci soc_button_array winbond_cir rc_core 8250_fintek int3403_thermal video int3402_thermal int3400_thermal acpi_thermal_rel int340x_thermal_zone acpi_pad mac_hid sunrpc parport_pc ppdev lp parport
[   88.897963]  autofs4 usbhid hid psmouse ahci sdhci_pci libahci sdhci_acpi sdhci
[   88.897966] CPU: 1 PID: 2080 Comm: kworker/u16:8 Tainted: G        W       4.0.0-996-generic #201503111121
[   88.897969] Hardware name: Intel Corporation Skylake Client platform/Skylake Y LPDDR3 RVP3, BIOS SKLSE2R1.86C.B066.R01.1501080220 01/08/2015
[   88.897976] Workqueue: events_unbound async_run_entry_fn
[   88.897980]  0000000000000e80 ffff88008a4afa68 ffffffff817df8df ffffffff81c4d508
[   88.897983]  ffff88008a4afab8 ffff88008a4afaa8 ffffffff810791a7 0000000000000286
[   88.897987]  ffff880148b1e000 ffff8800366f9000 ffff8800366f91a8 ffff8800893b86d0
[   88.897988] Call Trace:
[   88.897992]  [<ffffffff817df8df>] dump_stack+0x45/0x57
[   88.897998]  [<ffffffff810791a7>] warn_slowpath_common+0x97/0xe0
[   88.898004]  [<ffffffff810792a6>] warn_slowpath_fmt+0x46/0x50
[   88.898010]  [<ffffffff810bafd7>] ? finish_wait+0x67/0x80
[   88.898051]  [<ffffffffc0872ea3>] intel_crtc_wait_for_pending_flips+0x1f3/0x200 [i915]
[   88.898056]  [<ffffffff810baea0>] ? prepare_to_wait_event+0x100/0x100
[   88.898094]  [<ffffffffc0873cdc>] intel_crtc_disable_planes+0x2c/0x140 [i915]
[   88.898129]  [<ffffffffc0874325>] haswell_crtc_disable+0x55/0x2d0 [i915]
[   88.898166]  [<ffffffffc0874d37>] intel_crtc_control+0x57/0x130 [i915]
[   88.898186]  [<ffffffffc080158a>] i915_drm_suspend+0xaa/0x1d0 [i915]
[   88.898206]  [<ffffffffc08016df>] i915_pm_suspend+0x2f/0x50 [i915]
[   88.898212]  [<ffffffff81402578>] pci_pm_suspend+0x88/0x140
[   88.898216]  [<ffffffff817c847a>] ? klist_next+0x8a/0x100
[   88.898221]  [<ffffffff814024f0>] ? pci_pm_freeze+0xe0/0xe0
[   88.898225]  [<ffffffff8151a5b8>] dpm_run_callback+0x58/0xd0
[   88.898229]  [<ffffffff8151a742>] __device_suspend+0x112/0x370
[   88.898233]  [<ffffffff8151b53f>] async_suspend+0x1f/0xa0
[   88.898240]  [<ffffffff8109b0ac>] async_run_entry_fn+0x4c/0x160
[   88.898246]  [<ffffffff81092094>] process_one_work+0x144/0x490
[   88.898250]  [<ffffffff81092afe>] worker_thread+0x11e/0x450
[   88.898253]  [<ffffffff810929e0>] ? create_worker+0x1f0/0x1f0
[   88.898257]  [<ffffffff81098769>] kthread+0xc9/0xe0
[   88.898263]  [<ffffffff810986a0>] ? flush_kthread_worker+0x90/0x90
[   88.898267]  [<ffffffff817ebf98>] ret_from_fork+0x58/0x90
[   88.898272]  [<ffffffff810986a0>] ? flush_kthread_worker+0x90/0x90
[   88.898274] ---[ end trace e37c0e2ec2c7edb5 ]---
[   89.189503] PM: suspend of devices complete after 60304.662 msecs
[   89.205444] PM: late suspend of devices complete after 15.927 msecs
[   89.208032] xhci_hcd 0000:00:14.0: System wakeup enabled by ACPI
[   89.221422] PM: noirq suspend of devices complete after 15.968 msecs
[   89.222460] ACPI: Preparing to enter system sleep state S3
[   89.242744] PM: Saving platform NVS memory
[   89.242751] Disabling non-boot CPUs ...
[   89.242779] intel_pstate CPU 1 exiting
[   89.243971] kvm: disabling virtualization on CPU1
[   89.243981] smpboot: CPU 1 is now offline
[   89.250023] intel_pstate CPU 2 exiting
[   89.251421] kvm: disabling virtualization on CPU2
[   89.252480] smpboot: CPU 2 is now offline
[   89.257918] intel_pstate CPU 3 exiting
[   89.258160] Broke affinity for irq 123
[   89.258165] Broke affinity for irq 124
[   89.259217] kvm: disabling virtualization on CPU3
[   89.259234] smpboot: CPU 3 is now offline
-->

so it takes 60s to suspend, and on resume the display is just blank. Tested on SKL-Y SDP.
Comment 1 Damien Lespiau 2015-05-21 16:57:21 UTC 
Right, so S3 support just landed in -nightly. Closing this then.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.