Bug 89574 - Expose libinput_config_click_method in libinput X11 driver
Summary: Expose libinput_config_click_method in libinput X11 driver
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/libinput (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on: 89332
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-13 21:01 UTC by Bastien Nocera
Modified: 2015-03-18 09:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bastien Nocera 2015-03-13 21:01:05 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=746181

I can't use my touchpad with its default configuration. Makes me look from windows to drop it from.

This is necessary for feature parity in Wayland and X11 in GNOME.
Comment 1 Bastien Nocera 2015-03-13 21:04:31 UTC
I didn't expose "none" in GNOME, just left it at "whatever the device default is", but I've now realised that it's not possible to reset it through the libinput API.

The default value will need to be saved in the code that uses libinput, or API be added.
Comment 2 Peter Hutterer 2015-03-15 22:17:57 UTC
Exposed as property since 0.8, see bug 89332.
I'll figure something out for the defaults.
Comment 3 Peter Hutterer 2015-03-16 00:43:14 UTC
Do you care about the xorg.conf setting? i.e. should the "revert to default" setting restore the actual device default or the default set by an xorg.conf.d snippet?
Comment 4 Bastien Nocera 2015-03-16 09:36:53 UTC
(In reply to Peter Hutterer from comment #2)
> Exposed as property since 0.8, see bug 89332.
> I'll figure something out for the defaults.

Took me 5 minutes to find it this morning, knowing what it was called...

(In reply to Peter Hutterer from comment #3)
> Do you care about the xorg.conf setting? i.e. should the "revert to default"
> setting restore the actual device default or the default set by an
> xorg.conf.d snippet?

Default as in hardware default.
Comment 5 Bastien Nocera 2015-03-16 11:21:40 UTC
(In reply to Bastien Nocera from comment #4)
> (In reply to Peter Hutterer from comment #2)
> > Exposed as property since 0.8, see bug 89332.
> > I'll figure something out for the defaults.
> 
> Took me 5 minutes to find it this morning, knowing what it was called...

Actually:

$ xinput | grep -i TouchPad
⎜   ↳ SynPS/2 Synaptics TouchPad              	id=16	[slave  pointer  (2)]
$ xinput list-props 16 | grep "libinput Click Methods Available"
$ rpm -q libinput xorg-x11-drv-libinput 
libinput-0.12.0-1.fc22.x86_64
xorg-x11-drv-libinput-0.8.0-2.fc22.x86_64
Comment 6 Peter Hutterer 2015-03-16 22:43:17 UTC
http://patchwork.freedesktop.org/patch/44771/
http://patchwork.freedesktop.org/patch/44772/


(In reply to Bastien Nocera from comment #5)
> $ xinput list-props 16 | grep "libinput Click Methods Available"
> $ rpm -q libinput xorg-x11-drv-libinput 
> libinput-0.12.0-1.fc22.x86_64
> xorg-x11-drv-libinput-0.8.0-2.fc22.x86_64

what's the evemu-describe of this device? This should only happen if you have a non-clickpad.
Comment 7 Bastien Nocera 2015-03-17 09:05:26 UTC
# EVEMU 1.2
# Input device name: "SynPS/2 Synaptics TouchPad"
# Input device ID: bus 0x11 vendor 0x02 product 0x07 version 0x1b1
# Supported events:
#   Event type 0 (EV_SYN)
#     Event code 0 (SYN_REPORT)
#     Event code 1 (SYN_CONFIG)
#     Event code 2 (SYN_MT_REPORT)
#     Event code 3 (SYN_DROPPED)
#     Event code 4 ((null))
#     Event code 5 ((null))
#     Event code 6 ((null))
#     Event code 7 ((null))
#     Event code 8 ((null))
#     Event code 9 ((null))
#     Event code 10 ((null))
#     Event code 11 ((null))
#     Event code 12 ((null))
#     Event code 13 ((null))
#     Event code 14 ((null))
#   Event type 1 (EV_KEY)
#     Event code 272 (BTN_LEFT)
#     Event code 325 (BTN_TOOL_FINGER)
#     Event code 328 (BTN_TOOL_QUINTTAP)
#     Event code 330 (BTN_TOUCH)
#     Event code 333 (BTN_TOOL_DOUBLETAP)
#     Event code 334 (BTN_TOOL_TRIPLETAP)
#     Event code 335 (BTN_TOOL_QUADTAP)
#   Event type 3 (EV_ABS)
#     Event code 0 (ABS_X)
#       Value   5324
#       Min     1472
#       Max     5678
#       Fuzz       0
#       Flat       0
#       Resolution 46
#     Event code 1 (ABS_Y)
#       Value   4445
#       Min     1408
#       Max     4732
#       Fuzz       0
#       Flat       0
#       Resolution 63
#     Event code 24 (ABS_PRESSURE)
#       Value      0
#       Min        0
#       Max      255
#       Fuzz       0
#       Flat       0
#       Resolution 0
#     Event code 28 (ABS_TOOL_WIDTH)
#       Value      0
#       Min        0
#       Max       15
#       Fuzz       0
#       Flat       0
#       Resolution 0
#     Event code 47 (ABS_MT_SLOT)
#       Value      0
#       Min        0
#       Max        1
#       Fuzz       0
#       Flat       0
#       Resolution 0
#     Event code 53 (ABS_MT_POSITION_X)
#       Value      0
#       Min     1472
#       Max     5678
#       Fuzz       8
#       Flat       0
#       Resolution 46
#     Event code 54 (ABS_MT_POSITION_Y)
#       Value      0
#       Min     1408
#       Max     4732
#       Fuzz       8
#       Flat       0
#       Resolution 63
#     Event code 57 (ABS_MT_TRACKING_ID)
#       Value      0
#       Min        0
#       Max    65535
#       Fuzz       0
#       Flat       0
#       Resolution 0
#     Event code 58 (ABS_MT_PRESSURE)
#       Value      0
#       Min        0
#       Max      255
#       Fuzz       0
#       Flat       0
#       Resolution 0
# Properties:
#   Property  type 0 (INPUT_PROP_POINTER)
#   Property  type 2 (INPUT_PROP_BUTTONPAD)
N: SynPS/2 Synaptics TouchPad
I: 0011 0002 0007 01b1
P: 05 00 00 00 00 00 00 00
B: 00 0b 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 01 00 00 00 00 00
B: 01 20 e5 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 01 00 00 00 00 00 00 00 00
B: 02 00 00 00 00 00 00 00 00
B: 03 03 00 00 11 00 80 60 06
B: 04 00 00 00 00 00 00 00 00
B: 05 00 00 00 00 00 00 00 00
B: 11 00 00 00 00 00 00 00 00
B: 12 00 00 00 00 00 00 00 00
B: 14 00 00 00 00 00 00 00 00
B: 15 00 00 00 00 00 00 00 00
B: 15 00 00 00 00 00 00 00 00
A: 00 1472 5678 0 0 46
A: 01 1408 4732 0 0 63
A: 18 0 255 0 0 0
A: 1c 0 15 0 0 0
A: 2f 0 1 0 0 0
A: 35 1472 5678 8 0 46
A: 36 1408 4732 8 0 63
A: 39 0 65535 0 0 0
A: 3a 0 255 0 0 0
Comment 8 Peter Hutterer 2015-03-18 00:07:32 UTC
no idea what's going on there, that's a standard synaptics pad and replaying the recording here exposes the property correctly too. did you check if the driver hooks to the device correcly? are all the other properties available?
Comment 9 Peter Hutterer 2015-03-18 01:22:33 UTC
commit 8d4e03570cbdbb53bae57452614cbe45b6eb46f8
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Mon Mar 16 09:33:17 2015 +1000

    Add "libinput something Default" properties
Comment 10 Bastien Nocera 2015-03-18 09:09:47 UTC
(In reply to Peter Hutterer from comment #8)
> no idea what's going on there, that's a standard synaptics pad and replaying
> the recording here exposes the property correctly too. did you check if the
> driver hooks to the device correcly? are all the other properties available?

It's reappeared:
	libinput Click Methods Available (285):	1, 1
	libinput Click Method Enabled (286):	1, 0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.