Created attachment 114383 [details] [review] nicesink: Add support for render buffer_list Attached patch adds support for buffer list in nicesink Additionally it also tries to avoid memory copy while reading the buffers contents. Patch is based on Tim-Philipp Müller implementation of gst-plugins-good/gst/udp/gstmultiudpsink.c
Thank you for your contribution. It would also be lovely to have unit tests for this as it's not trivial.
Currently I am testing this with an small program that launches two gstreamer pipelines and send media from one to the other. I do not consider this as a unit test, but will it be suitable for you?
I meant something much more unity, which crafts various bufferlist "variants", sends them, and checks that the right content arrives on the other side.
Created attachment 114579 [details] [review] nicesink: Add test for buffer list support This patch adds a unit test for buffer list support. Sends a buffer list with buffers containing multiple memories and checks that a nicesrc receives exactly the same amount of data.
Thank you so much, patches merged. commit 20ea22e0a11a9bdfe4d8125b68083249b694338a Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com> Date: Tue Mar 24 12:07:34 2015 +0100 nicesink: Add test for buffer list support https://bugs.freedesktop.org/show_bug.cgi?id=89609 commit 781f3ab12c48c79da13dee4073f56a3936a5dced Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com> Date: Tue Mar 17 11:00:26 2015 +0100 nicesink: Add support for render buffer_list Also memory copies are reduced if buffers are fragmented https://bugs.freedesktop.org/show_bug.cgi?id=89609
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.