Bug 89742 - [all regression] igt/ drv_module_reload fails
Summary: [all regression] igt/ drv_module_reload fails
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-24 09:24 UTC by ye.tian
Modified: 2016-09-30 16:24 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg info (92.85 KB, text/plain)
2015-03-24 09:24 UTC, ye.tian
no flags Details
.config file (5.70 KB, text/plain)
2015-04-07 02:57 UTC, ye.tian
no flags Details

Description ye.tian 2015-03-24 09:24:39 UTC
Created attachment 114576 [details]
dmesg info

==System Environment==      
-----------------------------------------------------
Regression: Yes, igt
Good commit: ebd8b32bc6f5046815e00a6bee7f7f6650591cce
Bad  commit: e7d26df4198af40c92292cb4209fd803fa02062f

Non-working platforms: all

==Kernel==
--------------------------------------------------
commit 26db3817223d120e791f36b6be1d52b1aece47c7
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Mar 23 10:36:14 2015 +0100

    drm-intel-nightly: 2015y-03m-23d-09h-35m-35s UTC integration manifest

==Bug detailed description==
-----------------------------
Module unloaded successfully, but it doesn't reload module.
It's igt regression. The return code is 0, and we reboot system after execute this case. 
I know that there is a bug 88573 about this issue.

Output:
[root@x-hsw24 tests]# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon0/: (M) frame buffer device
module successfully unloaded
failed to reload module successfully
[root@x-hsw24 tests]# echo $?
0
[root@x-hsw24 tests]# ./drv_module_reload
 i915 debugfs path not found.
Reproduce steps:
----------------------------
1, ./drv_module_reload
Comment 1 Jesse Barnes 2015-04-02 21:09:45 UTC
Hm reload worked for me today on -nightly.  Does this still happen?
Comment 2 ye.tian 2015-04-03 03:10:31 UTC
(In reply to Jesse Barnes from comment #1)
> Hm reload worked for me today on -nightly.  Does this still happen?

 Yes, this still happens on the latest kernel.

igt version:

commit e8457edba6c41c4d44758e28adabf864be764c00
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Apr 2 20:14:07 2015 +0100

    igt/gem_exec_blt: Prevent assertion failure when running as a test load


output:
-----------
kernel: drm-intel-nightly_333cf6_20150403
[root@x-hsw27 tests]# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon0/: (M) frame buffer device
module successfully unloaded
failed to reload module successfully

kernel: drm-intel-fixes_840a1c_20150403
root@x-sgb3:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon1/: (M) frame buffer device
rmmod: ERROR: Module i915 is in use
WARNING: i915.ko still loaded!
Comment 3 Jesse Barnes 2015-04-03 16:15:20 UTC
This is probably a .config issue then; my unload/reload has been working for awhile across multiple platforms.
Comment 4 ye.tian 2015-04-07 02:57:08 UTC
Created attachment 114897 [details]
.config file
Comment 5 Thomas Wood 2015-04-22 15:22:25 UTC
The description mentions that this is an issue with intel-gpu-tools. Can you verify that this is still the case? Does drv_module_reload still return 0 even on failure?
Comment 6 ye.tian 2015-04-23 02:10:48 UTC
Tested it on sgb/bdw/bsw/ with the latest nightly kernel(b9fe35) and latest igt (e1ce5eac3), it still exists.

output:
-------------

root@x-bdw21:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon1/: (M) frame buffer device
module successfully unloaded
module successfully loaded again
root@x-bdw21:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# echo $?
0

root@x-bsw08:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon1/: (M) frame buffer device
module successfully unloaded
module successfully loaded again
root@x-bsw08:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# echo $?
0

root@x-sgb3:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon1/: (M) frame buffer device
rmmod: ERROR: Module i915 is in use
WARNING: i915.ko still loaded!
root@x-sgb3:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# echo $?
1
Comment 7 Thomas Wood 2015-04-23 13:59:59 UTC
(In reply to ye.tian from comment #6)
> Tested it on sgb/bdw/bsw/ with the latest nightly kernel(b9fe35) and latest
> igt (e1ce5eac3), it still exists.

It looks like the exit code issue has been fixed and the test is now failing only on one of the platforms you tried. Please update the title to indicate the platforms it fails on.
Comment 8 lu hua 2015-05-13 07:41:41 UTC
It happens on all platforms.
Test on the latest drm-intel-nightly kernel, it still exists. It works well on drm-intel-fixes kernel.
Comment 9 ye.tian 2015-05-18 03:21:32 UTC
Test it on the latest nightly kernel, it does not exist on SNB.
So verified.

output:
-------------
root@x-sgb5:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon1/: (M) frame buffer device
module successfully unloaded
module successfully loaded again

[root@x-ivb9 tests]# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon0/: (M) frame buffer device
module successfully unloaded
module successfully loaded again

root@x-hsw24:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon0/: (M) frame buffer device
module successfully unloaded
module successfully loaded again
Comment 10 Jari Tahvanainen 2016-09-30 16:24:30 UTC
Closing Verified+Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.