Bug 89867 - Need a cubemap normalization pass in NIR
Summary: Need a cubemap normalization pass in NIR
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Jason Ekstrand
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 00:14 UTC by Matt Turner
Modified: 2015-04-04 00:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Matt Turner 2015-04-02 00:14:51 UTC 
Like brw_do_cubemap_normalize in GLSL IR and the implementation in the TEXTURE_CUBE_INDEX case of brw_fs_fp.cpp, we need an implementation in NIR.

Ken and I suspect this is currently broken with prog -> NIR. Filing a bug so we don't forget.
Comment 1 Kenneth Graunke 2015-04-04 00:02:49 UTC 
Jason went ahead and fixed this.

commit 1bd1fc248ce5ecc6882309ab64ec61835fea1eda
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Thu Apr 2 17:04:28 2015 -0700

    i965: Use brw_nir_cubemap_normalize for NIR shaders

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.