Bug 89982 - gnuefi ldsdir check uses guessed $efiroot instead of $EFI_LIB_DIR
Summary: gnuefi ldsdir check uses guessed $efiroot instead of $EFI_LIB_DIR
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Kay Sievers
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-11 13:17 UTC by Michał Górny
Modified: 2015-04-21 17:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Michał Górny 2015-04-11 13:17:39 UTC 
If --with-efi-ldsdir is not passed, systemd guesses:

  [AS_FOR([DIR], [EFI_LDS_DIR], ["${efiroot}/gnuefi" "${efiroot}"],
          [AC_CHECK_FILE([${EFI_LDS_DIR}/elf_${EFI_ARCH}_efi.lds],
                         [have_efi_lds=yes && break])])])

However, since just before I have overrode $efiroot with --with-efi-libdir, it would seem reasonable to try that one ($EFI_LIB_DIR) instead.
Comment 1 Kay Sievers 2015-04-21 12:21:15 UTC 
Hmm, I have trouble parsing the text.

Please explain what you are looking for, or just propose a patch.
Comment 2 Michał Górny 2015-04-21 15:08:04 UTC 
I'm thinking the following may be better:

  [AS_FOR([DIR], [EFI_LDS_DIR], ["${EFI_LIB_DIR}/gnuefi" "${EFI_LIB_DIR}"],
          [AC_CHECK_FILE([${EFI_LDS_DIR}/elf_${EFI_ARCH}_efi.lds],
                         [have_efi_lds=yes && break])])])

i.e. $EFI_LIB_DIR (--with-efi-libdir=) instead of $efiroot (default path).
Comment 3 Kay Sievers 2015-04-21 17:49:11 UTC 
Seems to work fine here. Applied. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.