Created attachment 115196 [details]
Linux distribution: ArchLinux
I am using Gnome 3.16.1 Wayland mode. I tripple tapped but it caused a right click instead of middle click.
Evemu-record is in the attachment.
I have not yet test it in Weston or any other compositors. Because I do not know how to enable tap-to-click on Weston.
In X11, pressing L/R button at the same time can also trigger a middle click (if the mouse or trackpad does not have a physical middle button). However I can not get this to work.
So now there is no way to get middle click to work on a 2-button trackpad.
Appended another evemu-record of L/R button click. Hope this problem can be solved as well.
Created attachment 115197 [details]
(In reply to m13253 from comment #0)
> Created attachment 115196 [details]
> 01. tripple_tap.txt
this looks like an incomplete recording, can you please re-attach a new one? the tripletap comes in before the device even sees two touches. I'd need the full recording from no fingers on the touchpad through to no fingers on the touchpad again.
(In reply to m13253 from comment #1)
> So now there is no way to get middle click to work on a 2-button trackpad.
only just got added, you'd need libinput from git (see Bug 89933)
> this looks like an incomplete recording, can you please re-attach a new one?
Yes, I did get a full recording -- starting from no fingers on the touchpad, then start recording, then tap three fingers at the same time, then leave all fingers.
Is it because I tapped so quickly, that evdev didn't even think I did a double-tap?
Also, I did no editing on the resulting file.
I'll try to compile a git version and do another record later this evening, to provide more info. Thanks.
huh, odd. in that case it looks like a kernel bug. the device has 2 slots but sends tripletap with only one slot open and used. libinput won't handle that correctly. What kernel version is this?
Created attachment 115226 [details]
Linux brilliant-laptop 3.19.3-3-ARCH #1 SMP PREEMPT Wed Apr 8 14:10:00 CEST 2015 x86_64 GNU/Linux
I tried tripple-tap at different speed. They all have BTN_TOOL_TRIPLETAP at the very beginning before evdev detects the second finger.
But it is fine under X11. I am not sure if it is a kernel bug.
Created attachment 115227 [details]
Seems like the kernel is at fault. And this line seems to be the problem:
I guess a "elantech_set_slot(dev, 1, num_fingers >= 2, x2, y2);" should fix the problem.
m13253: any chance you can locally test this quick fix?
(In reply to Peter Hutterer from comment #9)
> m13253: any chance you can locally test this quick fix?
Thank you for the patch.
I am building the patched Linux kernel package now.
But my computer is too slow to finish building within two hours before I go to sleep.
I'll report the result tomorrow.
Lots of thanks.
Created attachment 115273 [details]
The fix worked. Thank you!
As a reference, I uploaded a record again.
Then, could you help me get this patch accepted by kernel upstream?
Lots of thanks.
(In reply to m13253 from comment #11)
> The fix worked. Thank you!
Thanks for the tests.
> Then, could you help me get this patch accepted by kernel upstream?
Given your results, I just submitted the patch here:
I marked it as stable so it will eventually end up in all supported long term kernels.
I'll close the bug when the patch hits the input maintainer's tree.
unrelated: what's the physical size of your touchpad? we need this for some other implementation. thanks
(In reply to Peter Hutterer from comment #14)
> unrelated: what's the physical size of your touchpad? we need this for some
> other implementation. thanks
Touch active area: 8.6 cm × 4.4 cm,
including the 1.0 cm right edge marked as scroll bar (not in use if two fingers scrolling is enabled),
excluding the two buttons at the bottom.
thanks, much appreciated