Bug 90140 - millions of warnings with drm-intel-next-queued
Summary: millions of warnings with drm-intel-next-queued
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 13:51 UTC by Andy Furniss
Modified: 2017-07-24 22:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg (48.43 KB, text/plain)
2015-04-22 13:51 UTC, Andy Furniss
no flags Details

Description Andy Furniss 2015-04-22 13:51:11 UTC
Created attachment 115272 [details]
dmesg

Baytrail J1900 I noticed on current drm-intel-next-queued I am getting logs flooded with -

[   23.087137] ------------[ cut here ]------------
[   23.087152] WARNING: CPU: 2 PID: 2885 at drivers/gpu/drm/i915/i915_gem_execbuffer.c:1256 i915_gem_ringbuffer_submission+0x888/0xb10()
[   23.087155] blitter ring didn't clear reload
[   23.087157] Modules linked in: plusb usbnet i2c_i801 r8169 mii coretemp iosf_mbi
[   23.087171] CPU: 2 PID: 2885 Comm: X Not tainted 4.0.0-rc7-00528-g2ebef63 #1
[   23.087174] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./Q1900DC-ITX, BIOS P1.20 07/08/2014
[   23.087177]  ffffffff81bf9d20 ffff8800a87a3b08 ffffffff818094be 0000000000000007
[   23.087182]  ffff8800a87a3b58 ffff8800a87a3b48 ffffffff8104f295 000000000000003e
[   23.087187]  ffff88013a40a000 ffff8800a9150000 0000000000000000 ffff8800a8b6b880
[   23.087192] Call Trace:
[   23.087200]  [<ffffffff818094be>] dump_stack+0x45/0x57
[   23.087206]  [<ffffffff8104f295>] warn_slowpath_common+0x85/0xc0
[   23.087211]  [<ffffffff8104f311>] warn_slowpath_fmt+0x41/0x50
[   23.087216]  [<ffffffff81438168>] i915_gem_ringbuffer_submission+0x888/0xb10
[   23.087221]  [<ffffffff814370fe>] i915_gem_do_execbuffer.isra.25+0xbce/0x1050
[   23.087228]  [<ffffffff8115e8b5>] ? __kmalloc+0xe5/0x1c0
[   23.087233]  [<ffffffff8143887c>] ? i915_gem_execbuffer2+0x6c/0x2b0
[   23.087237]  [<ffffffff814388c1>] i915_gem_execbuffer2+0xb1/0x2b0
[   23.087243]  [<ffffffff813f7661>] drm_ioctl+0x191/0x670
[   23.087250]  [<ffffffff8117a770>] do_vfs_ioctl+0x2e0/0x4e0
[   23.087256]  [<ffffffff812af077>] ? file_has_perm+0x87/0xa0
[   23.087261]  [<ffffffff81043844>] ? __do_page_fault+0x1c4/0x440
[   23.087266]  [<ffffffff8117a9f1>] SyS_ioctl+0x81/0xa0
[   23.087272]  [<ffffffff81811c32>] system_call_fastpath+0x12/0x17
[   23.087275] ---[ end trace a229d1cce5246988 ]---
[   23.742126] ------------[ cut here ]------------
[   23.742142] WARNING: CPU: 2 PID: 2885 at drivers/gpu/drm/i915/i915_gem_execbuffer.c:1256 i915_gem_ringbuffer_submission+0x888/0xb10()
[   23.742168] blitter ring didn't clear reload
[   23.742170] Modules linked in: plusb usbnet i2c_i801 r8169 mii coretemp iosf_mbi
[   23.742183] CPU: 2 PID: 2885 Comm: X Tainted: G        W       4.0.0-rc7-00528-g2ebef63 #1
[   23.742186] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./Q1900DC-ITX, BIOS P1.20 07/08/2014
[   23.742190]  ffffffff81bf9d20 ffff8800a87a3b08 ffffffff818094be ffffffff81e3ad58
[   23.742195]  ffff8800a87a3b58 ffff8800a87a3b48 ffffffff8104f295 000000000000003e
[   23.742199]  ffff88013a40a000 ffff8800a9150000 0000000000000040 ffff8800a8b6b240
[   23.742204] Call Trace:
[   23.742213]  [<ffffffff818094be>] dump_stack+0x45/0x57
[   23.742219]  [<ffffffff8104f295>] warn_slowpath_common+0x85/0xc0
[   23.742224]  [<ffffffff8104f311>] warn_slowpath_fmt+0x41/0x50
[   23.742229]  [<ffffffff81438168>] i915_gem_ringbuffer_submission+0x888/0xb10
[   23.742234]  [<ffffffff814370fe>] i915_gem_do_execbuffer.isra.25+0xbce/0x1050
[   23.742240]  [<ffffffff811204f1>] ? __lru_cache_add+0x51/0x70
[   23.742247]  [<ffffffff8115e8b5>] ? __kmalloc+0xe5/0x1c0
[   23.742251]  [<ffffffff8143887c>] ? i915_gem_execbuffer2+0x6c/0x2b0
[   23.742256]  [<ffffffff814388c1>] i915_gem_execbuffer2+0xb1/0x2b0
[   23.742262]  [<ffffffff813f7661>] drm_ioctl+0x191/0x670
[   23.742268]  [<ffffffff8117a770>] do_vfs_ioctl+0x2e0/0x4e0
[   23.742274]  [<ffffffff812af077>] ? file_has_perm+0x87/0xa0
[   23.742279]  [<ffffffff81043844>] ? __do_page_fault+0x1c4/0x440
[   23.742284]  [<ffffffff8117a9f1>] SyS_ioctl+0x81/0xa0
[   23.742289]  [<ffffffff81043acc>] ? do_page_fault+0xc/0x10
[   23.742294]  [<ffffffff81811c32>] system_call_fastpath+0x12/0x17
[   23.742297] ---[ end trace a229d1cce5246989 ]---
Comment 1 Chris Wilson 2015-04-23 15:12:04 UTC
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index a1a9f5dad541..006d4a2610f7 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -1562,6 +1562,8 @@ int i915_ppgtt_init_hw(struct drm_device *dev)
                        ret = ppgtt->switch_mm(ppgtt, ring);
                        if (ret != 0)
                                return ret;
+
+                       ppgtt->pd_dirty_rings &= ~(1 << i);
                }
        }
Comment 2 Andy Furniss 2015-04-23 16:50:35 UTC
(In reply to Chris Wilson from comment #1)
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
> b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index a1a9f5dad541..006d4a2610f7 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1562,6 +1562,8 @@ int i915_ppgtt_init_hw(struct drm_device *dev)
>                         ret = ppgtt->switch_mm(ppgtt, ring);
>                         if (ret != 0)
>                                 return ret;
> +
> +                       ppgtt->pd_dirty_rings &= ~(1 << i);
>                 }
>         }

This fixes it.
Comment 3 Mika Kuoppala 2015-04-30 06:58:32 UTC
This should be fixed by:

commit 71b7e54f71b899db9f8def67a0e976969384e699
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Apr 14 17:35:18 2015 +0200

    drm/i915: Don't look at pg_dirty_rings for aliasing ppgtt


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.