Bug 90178 - RFE: RuntimeDirectory= should resolve %i and other specifiers
Summary: RFE: RuntimeDirectory= should resolve %i and other specifiers
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-25 19:28 UTC by contact
Modified: 2016-06-07 11:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Derived from the service file included in the Arch "hhvm" package. (479 bytes, text/plain)
2015-04-25 19:28 UTC, contact
Details
load-fragment: resolve specifiers in RuntimeDirectory (1.47 KB, patch)
2015-09-17 21:00 UTC, Michael Gebetsroither
Details | Splinter Review

Description contact 2015-04-25 19:28:11 UTC
Created attachment 115328 [details]
Derived from the service file included in the Arch "hhvm" package.

RuntimeDirectory currently ignores %i in instanceable service files; RuntimeDirectory=%i for instance would create /run/%i
Comment 1 Michael Gebetsroither 2015-09-17 19:40:45 UTC
We actually fell into the same trap.
Please support %i expansion in RuntimeDirectory.
Comment 2 Michael Gebetsroither 2015-09-17 21:00:03 UTC
Created attachment 118333 [details] [review]
load-fragment: resolve specifiers in RuntimeDirectory
Comment 3 Michael Gebetsroither 2015-09-17 21:01:09 UTC
Please take this patch with a big grain of salt, i'm currently not even able to compile check the patch, hope it helps anyway to get this bug resolved.
Comment 4 Lennart Poettering 2015-09-18 09:33:18 UTC
Patch looks mostly good. But could you file it as github PR please?
Comment 5 Michael Gebetsroither 2015-09-18 09:55:32 UTC
done: https://github.com/systemd/systemd/pull/1292

thx for the fast response :)!
Comment 6 Lennart Poettering 2016-06-07 11:01:40 UTC
This got merged via github a while back. Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.