Bug 90199 - 1.8.16 not creating dbus-1-3.dll
Summary: 1.8.16 not creating dbus-1-3.dll
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.8
Hardware: Other Windows (All)
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard:
Keywords:
Depends on: 74117
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-27 17:45 UTC by rony
Modified: 2015-07-21 16:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description rony 2015-04-27 17:45:52 UTC
When creating the Windows version 1.8.16 of Dbus, the generated dbus-1.lib points to dbus-1-3.dll, however only dbus-1.dll gets created. As a result Windows programs linked against dbus-1.lib cannot successfully resolve at runtime as dbus-1-3.dll is missing.

(For "trunk"-versions ist seems that both get created, dbus-1.dll and dbus-1-3.dll.)
Comment 1 Ralf Habacker 2015-04-27 20:02:18 UTC
(In reply to rony from comment #0)
> When creating the Windows version 1.8.16 of Dbus, the generated dbus-1.lib
> points to dbus-1-3.dll, however only dbus-1.dll gets created. As a result
> Windows programs linked against dbus-1.lib cannot successfully resolve at
> runtime as dbus-1-3.dll is missing.
> (For "trunk"-versions ist seems that both get created, dbus-1.dll and
> dbus-1-3.dll.)

This bug has been fixed with bug 74117. To fix this issue in dbus-1.8 branch the related patch (attachment 93016 [details] [review]) needs to be applied to the dbus-1.8 branch.
Comment 2 Simon McVittie 2015-04-28 08:56:00 UTC
(In reply to rony from comment #0)
> When creating the Windows version 1.8.16 of Dbus

With Automake, or with CMake?

(In reply to Ralf Habacker from comment #1)
> This bug has been fixed with bug 74117.

Is this something that had never worked correctly in any branch until Bug #74117 was fixed, or is it a regression since some earlier stable version?
Comment 3 Ralf Habacker 2015-04-28 14:03:26 UTC
(In reply to Simon McVittie from comment #2)
> (In reply to rony from comment #0)
> > When creating the Windows version 1.8.16 of Dbus
> 
> With Automake, or with CMake?
cmake
> 
> Is this something that had never worked correctly in any branch until Bug
> #74117 was fixed 
yes
Comment 4 Ralf Habacker 2015-04-28 14:53:40 UTC
(In reply to Ralf Habacker from comment #1)
> (In reply to rony from comment #0)
> > When creating the Windows version 1.8.16 of Dbus, the generated dbus-1.lib
> > points to dbus-1-3.dll, however only dbus-1.dll gets created. As a result
> > Windows programs linked against dbus-1.lib cannot successfully resolve at
> > runtime as dbus-1-3.dll is missing.

This looks like a msvc specific problem. Cross compiled dbus-1.8 applications with cmake and mingw like dbus-monitor.exe links to libdbus-1.dll and not to *-3.dll

cd ....dbus-1.8-cmake-cross-build
objdump -x bin/dbus-monitor.exe
...
 The Import Tables (interpreted .idata section contents)
 vma:            Hint    Time      Forward  DLL       First
                 Table   Stamp     Chain    Name      Thunk
 00008000       00008050 00000000 00000000 00008910 0000819c

        DLL Name: libdbus-1.dll
        vma:  Hint/Ord Member-Name 
....
Comment 5 Simon McVittie 2015-04-28 17:50:27 UTC
(In reply to Ralf Habacker from comment #3)
> > Is this something that had never worked correctly in any branch until Bug
> > #74117 was fixed 
> yes

If that's the case, then I'd be inclined to leave this as-is in the 1.8 branch: everything that previously worked still works, and the underlying issue is fixed in master.

(I'm open to persuasion, though: Attachment #93016 [details] is a bigger diff than I'd ideally like in a stable-branch, but at least it only touches the CMake build system.)
Comment 6 Simon McVittie 2015-07-21 16:07:48 UTC
(In reply to Simon McVittie from comment #5)
> everything that previously worked still works, and the underlying
> issue is fixed in master

Closing this WONTFIX on that basis. I'm planning to do a 1.10 release before very long, which will supersede 1.8 as the stable branch.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.